acp_thread: Stream in agent text in a more continous manner#51499
Merged
acp_thread: Stream in agent text in a more continous manner#51499
Conversation
tommyming
pushed a commit
to tommyming/zed
that referenced
this pull request
Mar 15, 2026
…stries#51499) Release Notes: - N/A *or* Added/Fixed/Improved ...
lukemarsden
added a commit
to helixml/zed
that referenced
this pull request
Apr 5, 2026
Upstream PR zed-industries#51499 added a StreamingTextBuffer that rate-limits how many bytes get revealed into the Markdown entity per tick, creating a smooth typewriter animation. However, content_only(cx) reads markdown.source() which only returns revealed bytes. This means EntryUpdated -> WebSocket sync sends incomplete content, causing the Go accumulator's baseline to drift behind reality. When patches are computed from this stale baseline, the frontend sees backwards edits that truncate text before tool calls. Fix: each 16ms timer tick now drains the entire pending buffer instead of limiting to bytes_to_reveal_per_tick. The timer still batches (avoids per-character markdown.append calls), but no bytes are withheld. This ensures content_only(cx) always returns all received content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Spec-Ref: helix-specs@b244b04d4:001694_during-streaming-i-still
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes: