editor: Prevent panic in lsp_symbols_at_cursor with diff hunks handling#51077
Merged
editor: Prevent panic in lsp_symbols_at_cursor with diff hunks handling#51077
lsp_symbols_at_cursor with diff hunks handling#51077Conversation
We will end up panicking either way in this situation
Member
Author
|
/cherry-pick preview |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
…ling (#51077) Fixes ZED-5M9 No test as I couldn't quite reproduce this, as the cause is mostly a guess Release Notes: - Fixed a panic in `lsp_symbols_at_cursor` when dealing with diff hunks
github-actions bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
…ling (#51077) Fixes ZED-5M9 No test as I couldn't quite reproduce this, as the cause is mostly a guess Release Notes: - Fixed a panic in `lsp_symbols_at_cursor` when dealing with diff hunks
zed-zippy bot
added a commit
that referenced
this pull request
Mar 9, 2026
…ling (#51077) (cherry-pick to stable) (#51080) Cherry-pick of #51077 to stable ---- Fixes ZED-5M9 No test as I couldn't quite reproduce this, as the cause is mostly a guess Release Notes: - Fixed a panic in `lsp_symbols_at_cursor` when dealing with diff hunks Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy bot
added a commit
that referenced
this pull request
Mar 9, 2026
…ling (#51077) (cherry-pick to preview) (#51079) Cherry-pick of #51077 to preview ---- Fixes ZED-5M9 No test as I couldn't quite reproduce this, as the cause is mostly a guess Release Notes: - Fixed a panic in `lsp_symbols_at_cursor` when dealing with diff hunks Co-authored-by: Lukas Wirth <lukas@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ZED-5M9
No test as I couldn't quite reproduce this, as the cause is mostly a guess
Release Notes:
lsp_symbols_at_cursorwhen dealing with diff hunks