Release Notes:

- Added/Fixed/Improved ...

Release Notes:

- N/A

Generated by 🚫 dangerJS against 3d5d2aa

Thanks for this! Instead of passing a bool to that function, should we just short-circuit and only check the old ones?

I think the other caller should pass false to preserve existing behavior (not true) and it might be clearer if the bool wasn't there

Hey @ConradIrwin,

I have updated all_paths_exist_with_a_directory to accept a timestamp instead of boolean.
With that recent_workspaces_on_disk only delete the workplace if it's not available and it's been more than 7 days long.

Thanks, that's much clearer!

@ojpro congratulations on your first contribution to Zed! A great QoL improvement, at that! 💖

Have a great weekend!

@ojpro I believe this PR is causing non-existent directories to appear in the recent project picker. Was that your intent?

I think the correct behavior would be to allow a grace period before deleting the rows from Sqlite, but to still avoid showing inaccessible directories in the picker. Am I missing something there?

If you get a chance, could you follow up and fix that?

Hey @maxbrunsfeld

Actually the intent is to only delete non-existence directories after a period (7 days by default), but if that project opened before that period end it should reset the grace period, and so on.

The use case is, if I have a project A, but on an external drive | Network, I open a project B (on device), Zed remove the reference to that project A because the drive is not mounted during that session.

I understand that we want to keep the directories in the database for seven days. But your change caused them to still show up in the recent projects picker (where they will then fail to open). I don't think that is a good behavior.

/cc @ojpro

Hey @maxbrunsfeld

Okay. I will make it show the projects on the picker only if they exist.

But your change caused them to still show up in the recent projects picker (where they will then fail to open)

The behaviour actually seems weirder than that. I deleted a project, restarted Zed, and opened that project from the picker. Zed opened it as an unsaved file in my current workspace.

Agree that non-existent projects should just be hidden.

Hey @maxbrunsfeld , @ConradIrwin

I have updated the logic to hide nonexisting workspaces from the picker if it within the grace period, instead of it being an empty file

#52638

If you open a workspace, then close it and delete it from disk, restarting Zed will cause this error:

ERROR [worktree] root path could not be canonicalized: canonicalizing "~/foo": No such file or directory (os error 2)

And it seems like Zed does not restart cleanly -- previously open workspaces are not reopened.

unable to produce the error

Hmm, I couldn't reproduce it again. Not sure if it's directly related then.