Skip to content

bedrock: Make thinking toggle toggle thinking#50673

Merged
bennetbo merged 7 commits intozed-industries:mainfrom
5herlocked:bedrock-thinking-toggle-integration
Mar 19, 2026
Merged

bedrock: Make thinking toggle toggle thinking#50673
bennetbo merged 7 commits intozed-industries:mainfrom
5herlocked:bedrock-thinking-toggle-integration

Conversation

@5herlocked
Copy link
Copy Markdown
Contributor

Release Notes:

  • Support for Native Thinking toggle instead of model variants

5herlocked and others added 2 commits February 24, 2026 17:08
Consolidate Claude thinking variants (e.g. ClaudeSonnet4_5Thinking) into
their base models. Thinking is now controlled by the UI toggle rather than
requiring separate model entries. The old '-thinking' serde aliases are
preserved for backward compatibility with existing settings.

Co-authored-by: Ona <no-reply@ona.com>
Remove the 6 duplicate Claude *Thinking enum variants from the Bedrock
model list. Each Claude model now supports thinking via the UI toggle
rather than requiring a separate model entry.

- Add supports_thinking() and thinking_mode() to bedrock::Model
- Add supported_effort_levels() for adaptive thinking models (4.6)
- Map thinking_effort from the request to adaptive effort levels
- Preserve serde aliases for backward compatibility with existing settings
- Update cross-region inference profiles and tests

Co-authored-by: Ona <no-reply@ona.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 4, 2026
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Mar 4, 2026
@SomeoneToIgnore SomeoneToIgnore added the area:ai Related to Agent Panel, Edit Prediction, Copilot, or other AI features label Mar 4, 2026
@5herlocked 5herlocked marked this pull request as ready for review March 16, 2026 21:14
@maxdeviant maxdeviant changed the title bedrock: Zed Thinking toggle now toggles thinking bedrock: Make thinking toggle toggle thinking Mar 16, 2026
@JosephTLyons JosephTLyons requested a review from benbrandt March 17, 2026 16:15
@bennetbo bennetbo assigned maxdeviant and bennetbo and unassigned benbrandt Mar 19, 2026
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Copy link
Copy Markdown
Member

@bennetbo bennetbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions github-actions bot added size/M and removed size/M labels Mar 19, 2026
@bennetbo bennetbo enabled auto-merge (squash) March 19, 2026 15:24
@bennetbo bennetbo merged commit 945f642 into zed-industries:main Mar 19, 2026
30 checks passed
AmaanBilwar pushed a commit to AmaanBilwar/zed that referenced this pull request Mar 20, 2026
Release Notes:

- Support for Native Thinking toggle instead of model variants

---------

Co-authored-by: Ona <no-reply@ona.com>
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
toshmukhamedov pushed a commit to toshmukhamedov/zed that referenced this pull request Mar 20, 2026
Release Notes:

- Support for Native Thinking toggle instead of model variants

---------

Co-authored-by: Ona <no-reply@ona.com>
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
AmaanBilwar pushed a commit to AmaanBilwar/zed that referenced this pull request Mar 23, 2026
Release Notes:

- Support for Native Thinking toggle instead of model variants

---------

Co-authored-by: Ona <no-reply@ona.com>
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ai Related to Agent Panel, Edit Prediction, Copilot, or other AI features cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants