markdown_preview: Fix not re-rendering issue when editing by agent#50583
Merged
Veykril merged 1 commit intozed-industries:mainfrom Mar 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47900
Root cause
The current markdown preview only re-renders on
EditorEvent::Edited, DirtyChanged, ExcerptsEdited, but agent edits are implemented viabuffer.edit()which does not guaranty to emit theEditorEvent::Editedevent. Causing the markdown preview stuck on the last received parsed markdown.Applied fix
Subscribing to
EditorEvent::BufferEditedwhen initializing the markdown preview view. This will cause the view to update when receivedBufferEditedevent including agent edits to the file.As is/ To be
zed_markdown_preview_as_is.mp4
zed_markdown_preview_to_be.mp4
Before you mark this PR as ready for review, make sure that you have:
Release Notes: