Skip to content

Add file icons for YAML, Helm and GitLab#50529

Merged
danilo-leal merged 5 commits intozed-industries:mainfrom
tzabbi:main
Mar 3, 2026
Merged

Add file icons for YAML, Helm and GitLab#50529
danilo-leal merged 5 commits intozed-industries:mainfrom
tzabbi:main

Conversation

@tzabbi
Copy link
Copy Markdown
Contributor

@tzabbi tzabbi commented Mar 2, 2026

Before you mark this PR as ready for review, make sure that you have:

  • Added a solid test coverage and/or screenshots from doing manual testing
  • Done a self-review taking into account security and performance aspects
  • Aligned any UI changes with the UI checklist

I used the icons from here:

FYI: I'm not familiar with Rust please review the rust code.

Release Notes:

  • Added file icons for YAML, Helm and GitLab files, and used the Docker icon for Containerfile.

- add additional detection for these files icons
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 2, 2026
@MrSubidubi MrSubidubi changed the title feat: add file icons for yaml, helm and gitlab Add file icons for YAML, Helm and GitLab Mar 2, 2026
@tzabbi tzabbi requested a review from MrSubidubi March 3, 2026 05:26
@tzabbi
Copy link
Copy Markdown
Contributor Author

tzabbi commented Mar 3, 2026

@MrSubidubi I added detections for Containerfile and docker-compose, ... I hope that is okay since I'm not quite familiar with your design rules.

Copy link
Copy Markdown
Member

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@danilo-leal danilo-leal enabled auto-merge (squash) March 3, 2026 12:47
@danilo-leal danilo-leal merged commit 58ad0ff into zed-industries:main Mar 3, 2026
28 checks passed
tahayvr pushed a commit to tahayvr/zed that referenced this pull request Mar 4, 2026
Before you mark this PR as ready for review, make sure that you have:
- [ ] Added a solid test coverage and/or screenshots from doing manual
testing
- [x] Done a self-review taking into account security and performance
aspects
- [x] Aligned any UI changes with the [UI
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)

I used the icons from here:
- GitLab: https://about.gitlab.com/press/press-kit/
- Helm: https://www.svgrepo.com/svg/330624/helm
- Yaml: https://icons.getbootstrap.com/icons/filetype-yml/

FYI: I'm not familiar with Rust please review the rust code.

Release Notes:

- Added file icons for YAML, Helm and GitLab files, and used the Docker
icon for `Containerfile`.

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
wzulfikar pushed a commit to wzulfikar/zed that referenced this pull request Mar 4, 2026
Before you mark this PR as ready for review, make sure that you have:
- [ ] Added a solid test coverage and/or screenshots from doing manual
testing
- [x] Done a self-review taking into account security and performance
aspects
- [x] Aligned any UI changes with the [UI
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)

I used the icons from here:
- GitLab: https://about.gitlab.com/press/press-kit/
- Helm: https://www.svgrepo.com/svg/330624/helm
- Yaml: https://icons.getbootstrap.com/icons/filetype-yml/

FYI: I'm not familiar with Rust please review the rust code.

Release Notes:

- Added file icons for YAML, Helm and GitLab files, and used the Docker
icon for `Containerfile`.

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants