agent_ui: Improve loading state when there's only a terminal call#50501
Merged
danilo-leal merged 2 commits intomainfrom Mar 2, 2026
Merged
agent_ui: Improve loading state when there's only a terminal call#50501danilo-leal merged 2 commits intomainfrom
danilo-leal merged 2 commits intomainfrom
Conversation
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…d-industries#50501) In the thread view, when the last block is an ongoing terminal tool call, we're not waiting for the LLM to generate content, but rather, we're waiting for the command to run so its output can be sent to the model. With that in mind, it doesn't make sense for the generating loading spinner to be visible. So, this PR, removes it. But I also took the opportunity to refine the terminal card header a bit, as well as make the "command running" spinner, as well as the stop button, visible for external agents, too. https://github.com/user-attachments/assets/c7e2865a-af9b-416b-a06a-908dffb916da In the video, you can see that given we only have a running-terminal tool call, there's no generation loading spinner. Release Notes: - Agent: Improved loading state for the thread view when there's only a running terminal command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the thread view, when the last block is an ongoing terminal tool call, we're not waiting for the LLM to generate content, but rather, we're waiting for the command to run so its output can be sent to the model. With that in mind, it doesn't make sense for the generating loading spinner to be visible. So, this PR, removes it. But I also took the opportunity to refine the terminal card header a bit, as well as make the "command running" spinner, as well as the stop button, visible for external agents, too.
Screenshot.2026-03-02.at.12.46.mp4
In the video, you can see that given we only have a running-terminal tool call, there's no generation loading spinner.
Release Notes: