Skip to content

agent_ui: Use main message editor for editing queued messages#50490

Merged
danilo-leal merged 7 commits intomainfrom
edit-queued-message
Mar 2, 2026
Merged

agent_ui: Use main message editor for editing queued messages#50490
danilo-leal merged 7 commits intomainfrom
edit-queued-message

Conversation

@danilo-leal
Copy link
Copy Markdown
Member

This PR changes the behavior of editing queued messages. Previously, you could type directly in the editor that was used to displayed a queued message. However, that felt a bit anxiety-inducing because there was a chance the message would get sent before you could've wrapped up your edits. And even if we blocked the message to get sent while focused on the editor, it could still be a bit unpredictable. So, with this PR, if you type on a queued message, the content of that message goes immediately back to the main message editor. Effectively, you're taking that message off the queue so you can edit it, and then if you hit enter (while there's a generation ongoing), that content goes back into the queue.

I believe this allows for a calmer editing experience when wanting to touch up or increment a queued message.

Here's a video of the flow:

Screenshot.2026-03-02.at.11.38.mp4

In the video, I'm showcasing a few things:

  • in case the main message editor already had content, the content from the edited queued message is appended to it. That avoids the user surprisingly losing information.
  • the fact that mention creases still work well and are not converted back into plain text

Release Notes:

  • Agent: Made editing queued messages better by moving the contnet back to the main message editor, avoiding the chance of it getting sent mid-editing.

@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Mar 2, 2026
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 2, 2026
@danilo-leal danilo-leal merged commit 0cf551f into main Mar 2, 2026
38 checks passed
@danilo-leal danilo-leal deleted the edit-queued-message branch March 2, 2026 16:02
tahayvr pushed a commit to tahayvr/zed that referenced this pull request Mar 4, 2026
…dustries#50490)

This PR changes the behavior of editing queued messages. Previously, you
could type directly in the editor that was used to displayed a queued
message. However, that felt a bit anxiety-inducing because there was a
chance the message would get sent before you could've wrapped up your
edits. And even if we blocked the message to get sent while focused on
the editor, it could still be a bit unpredictable. So, with this PR, if
you type on a queued message, the content of that message goes
immediately back to the main message editor. Effectively, you're taking
that message off the queue so you can edit it, and then if you hit enter
(while there's a generation ongoing), that content goes back into the
queue.

I believe this allows for a calmer editing experience when wanting to
touch up or increment a queued message.

Here's a video of the flow:


https://github.com/user-attachments/assets/ec60ccad-2b04-4b7c-a8f5-95baa443d9f2

In the video, I'm showcasing a few things:
- in case the main message editor already had content, the content from
the edited queued message is appended to it. That avoids the user
surprisingly losing information.
- the fact that mention creases still work well and are not converted
back into plain text

Release Notes:

- Agent: Made editing queued messages better by moving the contnet back
to the main message editor, avoiding the chance of it getting sent
mid-editing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant