markdown_preview: Remove recoverable_panic and fix mermaid hex parsing panic#50470
Merged
smitbarmase merged 1 commit intomainfrom Mar 2, 2026
Merged
markdown_preview: Remove recoverable_panic and fix mermaid hex parsing panic#50470smitbarmase merged 1 commit intomainfrom
recoverable_panic and fix mermaid hex parsing panic#50470smitbarmase merged 1 commit intomainfrom
Conversation
4f538fd to
01df0b4
Compare
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…ing panic (zed-industries#50470) zed-industries#50176 added `recoverable_panic` to swallow mermaid panics, then zed-industries#50280 fixed it in upstream. This PR removes the workaround so future panics reach Sentry. Also bumps `mermaid-rs-renderer` to fix a hex parsing panic. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#50176 added
recoverable_panicto swallow mermaid panics, then #50280 fixed it in upstream. This PR removes the workaround so future panics reach Sentry. Also bumpsmermaid-rs-rendererto fix a hex parsing panic.Release Notes: