Adjust scroll top by number of sticky headers#50359
Merged
KyleBarton merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
In cases where sticky headers are enabled, count the number of sticky headers that would be present when performing `editor:scroll cursor top`. Take the maximum of that number and `verical_scroll_margin` so that we don't inadvertently bury the cursor behind the sticky headers. https://github.com/user-attachments/assets/6d49fe3a-2017-4c76-bd92-c4ec9794f898 Closes zed-industries#48864 Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed scroll top behavior when there are more sticky headers than vertical_scroll_margin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where sticky headers are enabled, count the number of sticky headers that would be present when performing
editor:scroll cursor top. Take the maximum of that number andverical_scroll_marginso that we don't inadvertently bury the cursor behind the sticky headers.Screen.Recording.2026-02-27.at.3.34.09.PM.mov
Closes #48864
Before you mark this PR as ready for review, make sure that you have:
Release Notes: