Dynamically detect surface size limits on WGPU (#50340) (cherry-pick to preview)#50348
Merged
ConradIrwin merged 1 commit intov0.226.xfrom Feb 27, 2026
Merged
Dynamically detect surface size limits on WGPU (#50340) (cherry-pick to preview)#50348ConradIrwin merged 1 commit intov0.226.xfrom
ConradIrwin merged 1 commit intov0.226.xfrom
Conversation
Fallout from #50270 Release Notes: - N/A Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
ConradIrwin
added a commit
that referenced
this pull request
Mar 2, 2026
…to preview) (#50348) Cherry-pick of #50340 to the preview branch (v0.226.x). The original PR changed `wgpu::Limits::downlevel_defaults()` to include `.using_resolution(adapter.limits()).using_alignment(adapter.limits())` to dynamically detect surface size limits. This cherry-pick required conflict resolution because the preview branch has a different code structure: - Preview uses a synchronous `create_device` function with `smol::block_on` - Preview doesn't have the WASM-related code paths - Preview used `wgpu::Limits::default()` instead of `wgpu::Limits::downlevel_defaults()` The change was adapted to apply the fix (`downlevel_defaults()` + `.using_resolution()` + `.using_alignment()`) to the preview branch's code structure. Release Notes: - N/A Co-authored-by: John Tur <john-tur@outlook.com> (cherry picked from commit 97db1f6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #50340 to the preview branch (v0.226.x).
The original PR changed
wgpu::Limits::downlevel_defaults()to include.using_resolution(adapter.limits()).using_alignment(adapter.limits())to dynamically detect surface size limits.This cherry-pick required conflict resolution because the preview branch has a different code structure:
create_devicefunction withsmol::block_onwgpu::Limits::default()instead ofwgpu::Limits::downlevel_defaults()The change was adapted to apply the fix (
downlevel_defaults()+.using_resolution()+.using_alignment()) to the preview branch's code structure.Release Notes: