Skip to content

Remove unwrap() from lsp::Uri::from_file_path#50244

Merged
ConradIrwin merged 2 commits intomainfrom
fix-lsp-panic
Feb 27, 2026
Merged

Remove unwrap() from lsp::Uri::from_file_path#50244
ConradIrwin merged 2 commits intomainfrom
fix-lsp-panic

Conversation

@ConradIrwin
Copy link
Member

Fixes ZED-3BM
Fixes ZED-1RT

Release Notes:

  • Windows: Fixed a panic registering a path with language servers when the UNC path cannot be represented by a Rust URI.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 26, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Feb 26, 2026
@ConradIrwin
Copy link
Member Author

/cherry-pick preview

@MrSubidubi MrSubidubi changed the title Remove unwrap() from lsp::Uri::from_file_path Remove unwrap() from lsp::Uri::from_file_path Feb 27, 2026
@ConradIrwin ConradIrwin merged commit e762bb9 into main Feb 27, 2026
43 of 45 checks passed
@ConradIrwin ConradIrwin deleted the fix-lsp-panic branch February 27, 2026 15:32
github-actions bot pushed a commit that referenced this pull request Feb 27, 2026
Fixes ZED-3BM
Fixes ZED-1RT

Release Notes:

- Windows: Fixed a panic registering a path with language servers when
the UNC path cannot be represented by a Rust URI.

---------

Co-authored-by: MrSubidubi <finn@zed.dev>
zed-zippy bot added a commit that referenced this pull request Feb 27, 2026
… to preview) (#50310)

Cherry-pick of #50244 to preview

----
Fixes ZED-3BM
Fixes ZED-1RT

Release Notes:

- Windows: Fixed a panic registering a path with language servers when
the UNC path cannot be represented by a Rust URI.

---------

Co-authored-by: MrSubidubi <finn@zed.dev>

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: MrSubidubi <finn@zed.dev>
tahayvr pushed a commit to tahayvr/zed that referenced this pull request Mar 4, 2026
Fixes ZED-3BM
Fixes ZED-1RT

Release Notes:

- Windows: Fixed a panic registering a path with language servers when
the UNC path cannot be represented by a Rust URI.

---------

Co-authored-by: MrSubidubi <finn@zed.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants