Skip to content

Remove notification panel#50204

Merged
Anthony-Eid merged 7 commits intomainfrom
move-friend-notifications-to-collab
Apr 7, 2026
Merged

Remove notification panel#50204
Anthony-Eid merged 7 commits intomainfrom
move-friend-notifications-to-collab

Conversation

@Anthony-Eid
Copy link
Copy Markdown
Contributor

@Anthony-Eid Anthony-Eid commented Feb 26, 2026

After chat functionality was removed, this panel became redundant. It only displayed three notification types: incoming contact requests, accepted contact requests, and channel invitations.

This PR moves those notifications into the collab experience by adding toast popups and a badge count to the collab panel. It also removes the notification-panel-specific settings, documentation, and Vim command.

Before you mark this PR as ready for review, make sure that you have:

  • Added a solid test coverage and/or screenshots from doing manual testing
  • Done a self-review taking into account security and performance aspects
  • Aligned any UI changes with the UI checklist

Release Notes:

  • Removed the notification panel from Zed

After chat functionality was removed this panel became redundent because
the three notification types it displayed (incoming/accepting contact
requests, and channel invitiations) could already be handled through the
collab panel.

This PR also add toast popups for notifcations and a badge count into
the collab panel. Finally, it removes all related notification panel
specific code which are settings, documentation, and a vim command
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 26, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Feb 26, 2026
@maxdeviant maxdeviant changed the title chore: Remove notification panel Remove notification panel Feb 26, 2026
@Anthony-Eid Anthony-Eid merged commit c5845ec into main Apr 7, 2026
30 checks passed
@Anthony-Eid Anthony-Eid deleted the move-friend-notifications-to-collab branch April 7, 2026 16:12
MasoudAlali pushed a commit to MasoudAlali/zed-ide that referenced this pull request Apr 7, 2026
After chat functionality was removed, this panel became redundant. It
only displayed three notification types: incoming contact requests,
accepted contact requests, and channel invitations.

This PR moves those notifications into the collab experience by adding
toast popups and a badge count to the collab panel. It also removes the
notification-panel-specific settings, documentation, and Vim command.

Before you mark this PR as ready for review, make sure that you have:
- [ ] Added a solid test coverage and/or screenshots from doing manual
testing
- [x] Done a self-review taking into account security and performance
aspects
- [x] Aligned any UI changes with the [UI
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)

Release Notes:

- Removed the notification panel from Zed
Caio-Ze added a commit to Caio-Ze/postprod-ide that referenced this pull request Apr 8, 2026
- Apply Patch 3: remove notification_panel references in zed.rs
  (collab_ui::notification_panel module deleted upstream in PR zed-industries#50204)
- Restore Cargo.lock from v0.232.0-pre tag
- Rename release profile package spec from zed to postprod-ide

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lukemarsden added a commit to helixml/zed that referenced this pull request Apr 9, 2026
Merge upstream zed-industries/zed main branch (7544515) into Helix fork.

Notable upstream changes:
- Agent V2 feature flag removal (zed-industries#52792)
- Sidebar/MultiWorkspace rework (zed-industries#53096, zed-industries#53032, zed-industries#53267)
- Agent panel git worktree/branch pickers (zed-industries#52979)
- Language model crate refactor (zed-industries#53270)
- Notification panel removal (zed-industries#50204)
- Subagent permission requests (zed-industries#53428)
- Worktree archival on thread archive (zed-industries#53215)
- Agent layout onboarding (zed-industries#52940)
- AuthRequired status for context servers (zed-industries#53396)

Conflict resolutions:
- crates/zed/Cargo.toml: kept external_websocket_sync feature + upstream track-project-leak
- crates/agent_ui/Cargo.toml: kept external_websocket_sync feature + upstream audio feature
- crates/agent_ui/src/agent_panel.rs: preserved all cfg-gated WebSocket blocks,
  migrated should_render_onboarding to should_render_new_user_onboarding,
  added upstream agent_layout_onboarding
- crates/agent/src/tools/context_server_registry.rs: added AuthRequired to match arm,
  preserved pending_tool_loads tracking
- crates/workspace/src/workspace.rs: added new upstream re-exports
- crates/title_bar/src/title_bar.rs: preserved Helix connection status indicator,
  dropped always-hidden onboarding banner (upstream removed it too)
- crates/recent_projects/src/dev_container_suggest.rs: kept suggest_dev_container check +
  upstream cli_auto_open
- .github/workflows, assets/keymaps, assets/settings, editor, multi_workspace: took upstream

Spec-Ref: helix-specs@e637a591b:001723_merge-latest-zed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants