Fix Collapse All Files button being limited to the current buffer#50076
Merged
JosephTLyons merged 2 commits intozed-industries:mainfrom Feb 26, 2026
Merged
Conversation
The click handler for the buffer search bar now uses the `cx.listener` pattern instead of directly dispatching the action. This approach properly binds the action handler to the component's context and ensures consistent behavior with other event handlers in the codebase.
Collapse All Files button limited to the current bufferCollapse All Files button being limited to the current buffer
rtfeldman
pushed a commit
that referenced
this pull request
Feb 27, 2026
…50076) Refactor buffer search bar click handler to use listener pattern The click handler for the buffer search bar now uses the `cx.listener` pattern instead of directly dispatching the action. This approach properly binds the action handler to the component's context and ensures consistent behavior with other event handlers in the codebase. Closes #ISSUE Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) before: https://github.com/user-attachments/assets/4fe5eaa4-be5c-4fe5-92d6-60a4f2059f7a after: https://github.com/user-attachments/assets/31238988-b664-4c4b-b143-e4d09c5f0a62 Release Notes: - Fixed the "Collapse All Files" button to work globally, now it's limited to the current buffer --------- Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…ed-industries#50076) Refactor buffer search bar click handler to use listener pattern The click handler for the buffer search bar now uses the `cx.listener` pattern instead of directly dispatching the action. This approach properly binds the action handler to the component's context and ensures consistent behavior with other event handlers in the codebase. Closes #ISSUE Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) before: https://github.com/user-attachments/assets/4fe5eaa4-be5c-4fe5-92d6-60a4f2059f7a after: https://github.com/user-attachments/assets/31238988-b664-4c4b-b143-e4d09c5f0a62 Release Notes: - Fixed the "Collapse All Files" button to work globally, now it's limited to the current buffer --------- Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
naaiyy
pushed a commit
to Glass-HQ/Glass
that referenced
this pull request
Mar 6, 2026
…ed-industries#50076) Refactor buffer search bar click handler to use listener pattern The click handler for the buffer search bar now uses the `cx.listener` pattern instead of directly dispatching the action. This approach properly binds the action handler to the component's context and ensures consistent behavior with other event handlers in the codebase. Closes #ISSUE Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) before: https://github.com/user-attachments/assets/4fe5eaa4-be5c-4fe5-92d6-60a4f2059f7a after: https://github.com/user-attachments/assets/31238988-b664-4c4b-b143-e4d09c5f0a62 Release Notes: - Fixed the "Collapse All Files" button to work globally, now it's limited to the current buffer --------- Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor buffer search bar click handler to use listener pattern
The click handler for the buffer search bar now uses the
cx.listenerpattern instead of directly dispatching the action. This approach properly binds the action handler to the component's context and ensures consistent behavior with other event handlers in the codebase.Closes #ISSUE
Before you mark this PR as ready for review, make sure that you have:
before:
2026-02-25.19.10.49.mov
after:
2026-02-25.19.12.03.mov
Release Notes: