Fix panic in can_resolve when passed an invalid excerpt ID#50052
Merged
maxdeviant merged 1 commit intomainfrom Feb 25, 2026
Merged
Fix panic in can_resolve when passed an invalid excerpt ID#50052maxdeviant merged 1 commit intomainfrom
maxdeviant merged 1 commit intomainfrom
Conversation
ConradIrwin
added a commit
that referenced
this pull request
Feb 25, 2026
pull bot
pushed a commit
to FlorianDevP/zed
that referenced
this pull request
Feb 25, 2026
…tries#50052) Fixes ZED-59F This is follow-up work from zed-industries#49994; which assumed that can_resolve would return false for an invalid excerpt id. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
pull bot
pushed a commit
to FlorianDevP/zed
that referenced
this pull request
Feb 25, 2026
…tries#50052) Fixes ZED-59F This is follow-up work from zed-industries#49994; which assumed that can_resolve would return false for an invalid excerpt id. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…tries#50052) Fixes ZED-59F This is follow-up work from zed-industries#49994; which assumed that can_resolve would return false for an invalid excerpt id. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ZED-59F
This is follow-up work from #49994; which assumed that can_resolve would return
false for an invalid excerpt id.
Before you mark this PR as ready for review, make sure that you have:
Release Notes: