Conversation
Remove both `git::LoadMoreHistory` and `git::ViewCommitFromHistory` actions as although both actions were registered in the workspace, they don't actually have effect when run. This appears to have been leftover from #42441 , possibly the initial implementation on how to open a commit and load more commits when the file history view was open, which is now handled with `Button.on_click` callbacks instead of relying on actions.
Anthony-Eid
pushed a commit
to bobbymannino/zed
that referenced
this pull request
Feb 25, 2026
Remove both `git::LoadMoreHistory` and `git::ViewCommitFromHistory` actions as although both actions were registered in the workspace, they don't actually have effect when run. This appears to have been leftover from zed-industries#42441 , possibly the initial implementation on how to open a commit and load more commits when the file history view was open, which is now handled with `Button.on_click` callbacks instead of relying on actions. Closes zed-industries#49288 Release Notes: - Removed unused git actions – `git: load more history` and `git: view commit from history`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove both
git::LoadMoreHistoryandgit::ViewCommitFromHistoryactions as although both actions were registered in the workspace, they don't actually have effect when run.This appears to have been leftover from
#42441 , possibly the initial implementation on how to open a commit and load more commits when the file history view was open, which is now handled with
Button.on_clickcallbacks instead of relying on actions.Closes #49288
Before you mark this PR as ready for review, make sure that you have:
Release Notes:
git: load more historyandgit: view commit from history