editor: Improve colorize_bracket highlight performance#49803
Merged
Conversation
Member
Author
|
/cherry-pick preview |
The binary search scheme in `highlight_text` does not handle large amounts of ranges well, so a more efficient approach is to just collect all elements and resort afterwards as that avoids constant memcpying
bfdcaed to
9955d93
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
The binary search insertion scheme in `highlight_text` works fine for small numbers of elements but does not handle large amounts of ranges well, as that will cause constant memcpying of the latter half of the vec. Bracket colorization tends to have a huge amount of entries though, so this can cause massive lags on the foreground thread. The better approach here is to just collect all elements and re-sort them once. Release Notes: - Reduced mini-stutters occuring due to large amount of bracket colorization in big buffers and agent diffs
zed-zippy bot
added a commit
that referenced
this pull request
Feb 21, 2026
…erry-pick to preview) (#49808) Cherry-pick of #49803 to preview ---- The binary search insertion scheme in `highlight_text` works fine for small numbers of elements but does not handle large amounts of ranges well, as that will cause constant memcpying of the latter half of the vec. Bracket colorization tends to have a huge amount of entries though, so this can cause massive lags on the foreground thread. The better approach here is to just collect all elements and re-sort them once. Release Notes: - Reduced mini-stutters occuring due to large amount of bracket colorization in big buffers and agent diffs Co-authored-by: Lukas Wirth <lukas@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binary search insertion scheme in
highlight_textworks fine for small numbers of elements but does not handle large amounts of ranges well, as that will cause constant memcpying of the latter half of the vec. Bracket colorization tends to have a huge amount of entries though, so this can cause massive lags on the foreground thread. The better approach here is to just collect all elements and re-sort them once.Release Notes: