Optimize workspace/didChangeWatchedFiles handler#49778
Merged
reflectronic merged 2 commits intozed-industries:mainfrom Feb 21, 2026
Merged
Optimize workspace/didChangeWatchedFiles handler#49778reflectronic merged 2 commits intozed-industries:mainfrom
workspace/didChangeWatchedFiles handler#49778reflectronic merged 2 commits intozed-industries:mainfrom
Conversation
reflectronic
added a commit
that referenced
this pull request
Feb 22, 2026
This reverts commit 21ac361.
reflectronic
added a commit
that referenced
this pull request
Feb 22, 2026
Reverts #49778 This seems to have made things much worse in some cases, so I'll have to think of a different way to fix the original issue. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
didChangeWatchedFilesregistrations triggered a rebuild of a singleGlobSetcontaining all file watch patterns for the language server. This means that, each timedidChangeWatchedFilesis registered, the work it takes to construct theGlobSetincreases. This quadratic blowup caused massive lag with language servers which register thousands of watched files (like Roslyn).Instead, create one
GlobSetper registration and try matching them one-by-one each time a file watcher event is raised.Before you mark this PR as ready for review, make sure that you have:
Release Notes: