ep: Fix panic when switching to a non-store provider#49698
Merged
Conversation
maxbrunsfeld
pushed a commit
that referenced
this pull request
Feb 27, 2026
The `unreachable()` assumption at `queue_prediction_refresh` could be violated by an async race condition: 1. `request_prediction_internal` spawns an async task 2. The task awaits a prediction request 3. If the prediction returns `None`, it calls `queue_prediction_refresh` 4. Between the time the prediction was initiated (when the provider was an EP-store provider) and when the async callback runs, the user can change their edit prediction provider setting to a non-EP-store provider 5. `queue_prediction_refresh` re-reads the settings and hits the `unreachable!() Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unreachable()assumption atqueue_prediction_refreshcould be violated by an async race condition:request_prediction_internalspawns an async taskNone, it callsqueue_prediction_refreshqueue_prediction_refreshre-reads the settings and hits the `unreachable!()Release Notes: