git_ui: Show uncommitted change count badge on git panel icon by IVainqueur · Pull Request #49624 · zed-industries/zed

IVainqueur · 2026-02-19T16:55:57Z

Summary

Implements icon_label on GitPanel to return the total count of uncommitted changes (new_count + changes_count) when non-zero, capped at "99+" for large repos.
Updates PanelButtons::render() to render that label as a small green badge overlaid on the panel's sidebar icon, using absolute positioning within a div().relative() wrapper.
The badge uses version_control_added theme color and LabelSize::XSmall text with LineHeightStyle::UiLabel for accurate vertical centering, positioned at the top-right corner of the icon button.

The icon_label method already existed on the Panel/PanelHandle traits with a default None impl, and was already implemented by NotificationPanel (unread notification count) and TerminalPanel (open terminal count) — but was never rendered. This wires it up for all three panels at once.

Notes

Badge is positioned with non-negative offsets (top(0), right(0)) to stay within the parent container's bounds. The status bar's render_left_tools() uses .overflow_x_hidden(), which in GPUI clips both axes (the overflow_mask returns a full content mask whenever any axis is non-Visible), so negative offsets would be clipped.
LineHeightStyle::UiLabel collapses line height to relative(1.) so flex centering aligns the visual glyph rather than a taller-than-necessary line box.
No new data tracking logic — GitPanel already maintains new_count and changes_count reactively.
No feature flag or settings added per YAGNI.

Suggested .rules additions

The following pattern came up repeatedly and would prevent future sessions from hitting the same issue:

## GPUI overflow clipping

`overflow_x_hidden()` (and any single-axis overflow setter) clips **both** axes in GPUI.
The `overflow_mask()` implementation in `style.rs` returns a full `ContentMask` (bounding box)
whenever any axis is non-`Visible`. Absolute-positioned children that extend outside the element
bounds will be clipped even if only the X axis is set to Hidden.
Avoid negative `top`/`right`/`bottom`/`left` offsets on absolute children of containers
that have any overflow hidden — keep badge/overlay elements within the parent's bounds instead.

Release Notes:

Added a numeric badge to the git panel sidebar icon showing the count of uncommitted changes.

cla-bot · 2026-02-19T16:56:01Z

We require contributors to sign our Contributor License Agreement, and we don't have @IVainqueur on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

IVainqueur · 2026-02-19T16:58:43Z

@cla-bot check

cla-bot · 2026-02-19T16:58:48Z

The cla-bot has been summoned, and re-checked this pull request!

Dima-369 · 2026-02-20T08:05:25Z

Hey, thanks. Mind sharing some screenshots?

Veykril · 2026-02-20T08:18:37Z

Yea a screenshot for this would be appreciated to aid in reviewing

IVainqueur · 2026-02-20T08:24:18Z

Sure thing.
(peep the bottom right corner)

Lemme know if it's clear enough or..?

bowenxuuu · 2026-02-20T15:15:12Z

The number 2 in the badge doesn't appear to be horizontally centered.

IVainqueur · 2026-02-23T12:17:41Z

Fixed, @bowenxuuu 👍🏼 Nice Catch!

danilo-leal

Heya, thanks for the PR! This is a cool change, but can we make it be under a setting that's turned off by default? I don't think we should have this at all times. And then, even with the setting, I think we should remove the badge if the panel is open.

IVainqueur · 2026-03-03T08:19:21Z

Good suggestion @danilo-leal, added.

Wires up the existing `icon_label` method on the `Panel` trait so that `GitPanel` exposes a count of uncommitted changes (new + modified files), and `PanelButtons` renders that label as a small green badge overlaid on the panel's sidebar icon — similar to VS Code's Source Control badge. `icon_label` already had implementations in `NotificationPanel` and `TerminalPanel` but was never rendered; this also benefits those panels.

- Set LineHeightStyle::UiLabel on the badge label so its line box matches the font height, making flex centering visually accurate - Cap the displayed count at "99+" to prevent oversized badges on repos with large numbers of changes

…l is open - Add `show_count_badge` setting to GitPanelSettings (off by default) - Hide the badge in the activity bar when the git panel is open - Add public `panels()` method to Dock for iterating panel handles Release Notes: - N/A

simonfelding · 2026-03-05T11:57:07Z

@danilo-leal I disagree that the count should not be visible when the panel is open. It is immensely useful if you're working with coding agents to see how many files they changed, and this can happen while the panel is open.

For users that like having this badge clearly visible, they will be used to glancing there to check the current status. While the panel does have a change counter already, but it's an unnecessary mental operation to have to shift where you read the change count depending on whether the panel is open or not.

It should also be enabled by default for users migrating from vscode.

danilo-leal

Thank you! I pushed several changes here, most notably:

There were what I think are changes from a different branch leaking on on this one (regarding an activity bar implementation, which is very unrelated to this PR). So I removed all of that.
Had to add settings to the terminal and notification panels given both also implement icon_label and I didn't want any badges appearing on them as a result of this PR.
Created a dedicated component for the count badge instead of creating it directly in the dock file.

@simonfelding, I hear and appreciate your take here, but I think for now we'll have to agree on disagreeing; we really want to preserve Zed's UI minimalism and this could be unnecessary noise. This doesn't mean I'm not open to change it, though, in case we get enough feedback pointing that the default should have it turned on; looking forward to seeing what people will think. But I think whenever not fully sure if something should be turned on by default, a good rule of thumb is to have it turned off.

simonfelding · 2026-03-16T19:36:28Z

Fair enough 🙂 Nice work!

kczx3 · 2026-03-18T19:12:45Z

Heya, thanks for the PR! This is a cool change, but can we make it be under a setting that's turned off by default? I don't think we should have this at all times. And then, even with the setting, I think we should remove the badge if the panel is open.

@danilo-leal I'm not familiar with the process here but should those new settings have been added to docs/src/reference/all-settings.md with this change? Similar to what was done in #51601.

danilo-leal · 2026-03-18T21:08:08Z

@kczx3 we should add them there, yes! Feel free to contribute if you're feeling like it :)

IVainqueur requested review from a team as code owners February 19, 2026 16:55

IVainqueur requested review from Veykril and reflectronic and removed request for a team February 19, 2026 16:55

zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Feb 19, 2026

maxdeviant changed the title ~~git_ui, workspace: Show uncommitted change count badge on git panel icon~~ git_ui: Show uncommitted change count badge on git panel icon Feb 19, 2026

cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 19, 2026

Veykril requested a review from danilo-leal February 23, 2026 12:19

smitbarmase assigned danilo-leal Feb 24, 2026

danilo-leal requested changes Feb 24, 2026

View reviewed changes

IVainqueur force-pushed the git-panel-icon-badge branch from e282f75 to 3fafda8 Compare March 3, 2026 08:18

IVainqueur added 3 commits March 5, 2026 12:34

git_ui: Fix badge text centering and cap count at 99+

eaf33d0

- Set LineHeightStyle::UiLabel on the badge label so its line box matches the font height, making flex centering visually accurate - Cap the displayed count at "99+" to prevent oversized badges on repos with large numbers of changes

IVainqueur force-pushed the git-panel-icon-badge branch from 3fafda8 to d884e9f Compare March 5, 2026 10:36

IVainqueur requested a review from danilo-leal March 5, 2026 10:37

danilo-leal added 3 commits March 16, 2026 11:02

Merge remote-tracking branch 'origin/main' into pr/49624

6b5a076

Remove everything related to the activity bar

37cfb37

Add setting that turns off the badge in other panels

59e5110

danilo-leal added 7 commits March 16, 2026 11:45

Improve badge implementation in the git panel

c323b47

Fix issue with VS Code terminal settings import

53f2b3b

Add CountBadge component

b807a88

Merge remote-tracking branch 'origin/main' into pr/49624

cd44ae4

Format file

df7d866

Standardize settings description

d11b9e5

Add settings UI for the notification and terminal panels settings

b4505f7

danilo-leal approved these changes Mar 16, 2026

View reviewed changes

danilo-leal merged commit ae44563 into zed-industries:main Mar 16, 2026
29 checks passed

Uh oh!

Conversation

IVainqueur commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Suggested .rules additions

Uh oh!

cla-bot bot commented Feb 19, 2026

Uh oh!

IVainqueur commented Feb 19, 2026

Uh oh!

cla-bot bot commented Feb 19, 2026

Uh oh!

Dima-369 commented Feb 20, 2026

Uh oh!

Veykril commented Feb 20, 2026

Uh oh!

IVainqueur commented Feb 20, 2026

Uh oh!

bowenxuuu commented Feb 20, 2026

Uh oh!

IVainqueur commented Feb 23, 2026

Uh oh!

danilo-leal left a comment

Choose a reason for hiding this comment

Uh oh!

IVainqueur commented Mar 3, 2026

Uh oh!

simonfelding commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danilo-leal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

simonfelding commented Mar 16, 2026

Uh oh!

kczx3 commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danilo-leal commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

IVainqueur commented Feb 19, 2026 •

edited

Loading

simonfelding commented Mar 5, 2026 •

edited

Loading

kczx3 commented Mar 18, 2026 •

edited

Loading