context_menu: Fix certain menu items not reacting to click events#49557
Merged
context_menu: Fix certain menu items not reacting to click events#49557
Conversation
Use `Workspace::for_window` instead of `window.root().flatten()`.
Anthony-Eid
pushed a commit
to bobbymannino/zed
that referenced
this pull request
Feb 25, 2026
…d-industries#49557) Use `Workspace::for_window` instead of `window.root().flatten()`. https://github.com/user-attachments/assets/3ea6dae3-166d-49e4-9fff-8256e13cc2bf https://github.com/user-attachments/assets/eb8d9394-5f71-4df6-b0db-c1c8078f1b9a Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed certain context menu items not reacting to click events
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…d-industries#49557) Use `Workspace::for_window` instead of `window.root().flatten()`. https://github.com/user-attachments/assets/3ea6dae3-166d-49e4-9fff-8256e13cc2bf https://github.com/user-attachments/assets/eb8d9394-5f71-4df6-b0db-c1c8078f1b9a Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed certain context menu items not reacting to click events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Workspace::for_windowinstead ofwindow.root().flatten().bun-blank.2026-02-23.13.49.03.mp4
bun-blank.2026-02-23.13.43.05.mp4
Before you mark this PR as ready for review, make sure that you have:
Release Notes: