languages: Reorder type identifier highlights in JavaScript#49325
Merged
languages: Reorder type identifier highlights in JavaScript#49325
Conversation
Move general type identifier rules before class-specific ones to ensure proper precedence in the syntax highlighting query.
rtfeldman
pushed a commit
that referenced
this pull request
Feb 27, 2026
Move general type identifier rules before class-specific ones to ensure proper precedence in the syntax highlighting query. Closes #49226. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed an issue where class names were not highlighted correctly in JavaScript files
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…stries#49325) Move general type identifier rules before class-specific ones to ensure proper precedence in the syntax highlighting query. Closes zed-industries#49226. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed an issue where class names were not highlighted correctly in JavaScript files
naaiyy
pushed a commit
to Glass-HQ/Glass
that referenced
this pull request
Mar 10, 2026
…stries#49325) Move general type identifier rules before class-specific ones to ensure proper precedence in the syntax highlighting query. Closes zed-industries#49226. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed an issue where class names were not highlighted correctly in JavaScript files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move general type identifier rules before class-specific ones to ensure proper precedence in the syntax highlighting query.
Closes #49226.
Before you mark this PR as ready for review, make sure that you have:
Release Notes: