Skip to content

Revert "gpui: Defer thermal/keyboard state updates when app is borrowed"#49251

Merged
bennetbo merged 2 commits intozed-industries:mainfrom
marcocondrache:iarluxnt
Feb 16, 2026
Merged

Revert "gpui: Defer thermal/keyboard state updates when app is borrowed"#49251
bennetbo merged 2 commits intozed-industries:mainfrom
marcocondrache:iarluxnt

Conversation

@marcocondrache
Copy link
Contributor

@marcocondrache marcocondrache commented Feb 16, 2026

Reverts #49189
Reverts #49187

#49189 introduces a panic (#49189 (comment), #49181 (comment))
#49187 It's wrong since it leads to missing updates

The original crash should be fixed with #49086

cc: @bennetbo

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 16, 2026
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Feb 16, 2026
@zed-industries-bot

This comment was marked as resolved.

@bennetbo bennetbo enabled auto-merge (squash) February 16, 2026 08:40
@bennetbo bennetbo merged commit c4f9868 into zed-industries:main Feb 16, 2026
31 checks passed
@bennetbo
Copy link
Member

Thank you, much appreciated 😄

@marcocondrache
Copy link
Contributor Author

@bennetbo thank you so much for handling this and sorry for the confusion it created!

rtfeldman pushed a commit that referenced this pull request Feb 17, 2026
…ed" (#49251)

Reverts #49189
Reverts #49187

#49189 introduces a panic
(#49189 (comment),
#49181 (comment))
#49187 It's wrong since it leads to missing updates

The original crash should be fixed with #49086

cc: @bennetbo 

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants