util: Always use posix_spawn on macOS even with pre_exec hooks#49090
Merged
util: Always use posix_spawn on macOS even with pre_exec hooks#49090
Conversation
Co-authored-by: Cole Miller <cole@zed.dev>
Contributor
b250a84 to
a22f0e6
Compare
f41af35 to
4823a99
Compare
4823a99 to
48b22cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's some backstory:
pre_exechook onstd::process::Commandwhich then abandonsposix_spawnsyscall forfork+execvedance on macOS (we tracked it down in Rust's std implementation)fork+execveis pretty expensive on macOS (apparently way more so than on other OSes like Linux) andforktakes a process-wide lock on the allocator which is badpre_exechookposix_spawnattr_setexceptionports_npbut there is no way to use that via any standard interfaces instd::process::Commandsmol::process::Command, while on macOS we reimplement the minimum to achievesmol::process::Commandwithposix_spawnunder-the-hoodNotably, this changeset improves git-blame in very large repos significantly.
Release Notes:
posix_spawnno matter what.