Fix Cmd+click navigating to file instead of definition#49012
Merged
SomeoneToIgnore merged 1 commit intozed-industries:mainfrom Feb 27, 2026
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @Bug93 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
7c96da6 to
5a0cec9
Compare
The `link_pattern_file_candidates` regex `\(([^)]*)\)` was intended to extract paths from Markdown links like `[title](path.md)`, but it matched any parenthesized content, including function call arguments. This caused `find_file` to incorrectly resolve e.g. `file2` from `do_work(file2)` as `file2.rs`, preempting LSP go-to-definition. Tighten the regex to `]\(([^)]*)\)` so only Markdown link syntax triggers path extraction. Release Notes: - Fixed Cmd+click (go-to-definition) incorrectly navigating to a file instead of the symbol definition when the hovered text contains parenthesized content resembling a file path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5a0cec9 to
55c0ed8
Compare
rtfeldman
pushed a commit
that referenced
this pull request
Feb 27, 2026
## Summary - Tighten `link_pattern_file_candidates` regex from `\(([^)]*)\)` to `]\(([^)]*)\)` so only Markdown link syntax `[title](path)` triggers path extraction from parentheses - Prevents function call arguments like `do_work(file2)` from being incorrectly resolved as file paths, which preempted LSP go-to-definition Closes #48938 ## Test plan - [x] `cargo test -p editor hover_links` — all 12 tests pass - [x] New unit tests verify: function calls don't extract arguments as file candidates; Markdown links still extract correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Release Notes: - Fixed Cmd+click navigating to file instead of definition in certain cases Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…s#49012) ## Summary - Tighten `link_pattern_file_candidates` regex from `\(([^)]*)\)` to `]\(([^)]*)\)` so only Markdown link syntax `[title](path)` triggers path extraction from parentheses - Prevents function call arguments like `do_work(file2)` from being incorrectly resolved as file paths, which preempted LSP go-to-definition Closes zed-industries#48938 ## Test plan - [x] `cargo test -p editor hover_links` — all 12 tests pass - [x] New unit tests verify: function calls don't extract arguments as file candidates; Markdown links still extract correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Release Notes: - Fixed Cmd+click navigating to file instead of definition in certain cases Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
naaiyy
pushed a commit
to Glass-HQ/Glass
that referenced
this pull request
Mar 10, 2026
…s#49012) ## Summary - Tighten `link_pattern_file_candidates` regex from `\(([^)]*)\)` to `]\(([^)]*)\)` so only Markdown link syntax `[title](path)` triggers path extraction from parentheses - Prevents function call arguments like `do_work(file2)` from being incorrectly resolved as file paths, which preempted LSP go-to-definition Closes zed-industries#48938 ## Test plan - [x] `cargo test -p editor hover_links` — all 12 tests pass - [x] New unit tests verify: function calls don't extract arguments as file candidates; Markdown links still extract correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Release Notes: - Fixed Cmd+click navigating to file instead of definition in certain cases Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
link_pattern_file_candidatesregex from\(([^)]*)\)to]\(([^)]*)\)so only Markdown link syntax[title](path)triggers path extraction from parenthesesdo_work(file2)from being incorrectly resolved as file paths, which preempted LSP go-to-definitionCloses #48938
Test plan
cargo test -p editor hover_links— all 12 tests pass🤖 Generated with Claude Code
Release Notes: