Handle newlines better in parse_edits#48960
Merged
eholk merged 2 commits intozed-industries:mainfrom Feb 12, 2026
Merged
Conversation
Co-authored-by: Ben Kunkle <ben@zed.dev>
morgankrey
added a commit
that referenced
this pull request
Feb 13, 2026
Add 3 regression tests for the edit_prediction parse_edits UTF-8 crash (ZED-4VS) that was fixed in PR #48960. These tests ensure the fix for multi-byte character handling near editable region markers won't regress. Tests added: - test_parse_edits_with_multibyte_utf8 - test_parse_edits_multibyte_before_end_marker - test_parse_edits_multibyte_after_start_marker_no_newline Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
morgankrey
added a commit
that referenced
this pull request
Feb 13, 2026
Add 3 regression tests for the edit_prediction parse_edits UTF-8 crash (ZED-4VS) that was fixed in PR #48960. These tests ensure the fix for multi-byte character handling near editable region markers won't regress. Tests added: - test_parse_edits_with_multibyte_utf8 - test_parse_edits_multibyte_before_end_marker - test_parse_edits_multibyte_after_start_marker_no_newline Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
|
/cherry-pick stable |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
Release Notes: - Fix a potential crash around multibyte characters in edit predictions --------- Co-authored-by: Ben Kunkle <ben@zed.dev>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
Release Notes: - Fix a potential crash around multibyte characters in edit predictions --------- Co-authored-by: Ben Kunkle <ben@zed.dev>
This was referenced Feb 17, 2026
eholk
pushed a commit
that referenced
this pull request
Feb 24, 2026
Add 3 regression tests for the edit_prediction parse_edits UTF-8 crash (ZED-4VS) that was fixed in PR #48960. These tests ensure the fix for multi-byte character handling near editable region markers won't regress. Tests added: - test_parse_edits_with_multibyte_utf8 - test_parse_edits_multibyte_before_end_marker - test_parse_edits_multibyte_after_start_marker_no_newline Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes: