Skip to content

editor: Fix documentation tooltip reappearing after editor regains focus#48924

Merged
Veykril merged 1 commit intozed-industries:mainfrom
feeiyu:fix-doc-tooltip
Mar 19, 2026
Merged

editor: Fix documentation tooltip reappearing after editor regains focus#48924
Veykril merged 1 commit intozed-industries:mainfrom
feeiyu:fix-doc-tooltip

Conversation

@feeiyu
Copy link
Copy Markdown
Contributor

@feeiyu feeiyu commented Feb 11, 2026

Closes #48922

When the editor regains focus, it internally triggers the mouse_moved logic again. This causes the hover documentation to be shown even if it was previously dismissed due to user editing.

This change skips mouse_moved handling when the cursor is hidden, preventing unintended tooltip popups.

2026-02-11.19-04-14.webm
  • Tests or screenshots needed?
  • Code Reviewed
  • Manual QA

Release Notes:

  • Fixed documentation tooltip reappearing after editor regains focus

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 11, 2026
@esthertrapadoux esthertrapadoux added the community champion Issues filed by our amazing community champions! 🫶 label Feb 11, 2026
@MrSubidubi MrSubidubi self-assigned this Feb 12, 2026
Copy link
Copy Markdown
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril enabled auto-merge (squash) March 17, 2026 07:24
@Veykril Veykril changed the title Fix documentation tooltip reappearing after editor regains focus editor: Fix documentation tooltip reappearing after editor regains focus Mar 17, 2026
@Veykril Veykril assigned Veykril and unassigned MrSubidubi Mar 17, 2026
@Veykril Veykril disabled auto-merge March 17, 2026 07:24
@Veykril Veykril enabled auto-merge (squash) March 17, 2026 07:25
@Veykril Veykril closed this Mar 19, 2026
auto-merge was automatically disabled March 19, 2026 07:57

Pull request was closed

@Veykril Veykril reopened this Mar 19, 2026
@Veykril Veykril enabled auto-merge (squash) March 19, 2026 07:57
@Veykril Veykril merged commit b165cd0 into zed-industries:main Mar 19, 2026
34 checks passed
AmaanBilwar pushed a commit to AmaanBilwar/zed that referenced this pull request Mar 20, 2026
…cus (zed-industries#48924)

Closes zed-industries#48922

When the editor regains focus, it internally triggers the mouse_moved
logic again. This causes the hover documentation to be shown even if it
was previously dismissed due to user editing.

This change skips mouse_moved handling when the cursor is hidden,
preventing unintended tooltip popups.


[录屏 2026-02-11
19-04-14.webm](https://github.com/user-attachments/assets/ea9f9438-34bf-4771-bbc8-335e9ea59dd7)

- [x] Tests or screenshots needed?
- [x] Code Reviewed
- [x] Manual QA

Release Notes:

- Fixed documentation tooltip reappearing after editor regains focus
toshmukhamedov pushed a commit to toshmukhamedov/zed that referenced this pull request Mar 20, 2026
…cus (zed-industries#48924)

Closes zed-industries#48922

When the editor regains focus, it internally triggers the mouse_moved
logic again. This causes the hover documentation to be shown even if it
was previously dismissed due to user editing.

This change skips mouse_moved handling when the cursor is hidden,
preventing unintended tooltip popups.


[录屏 2026-02-11
19-04-14.webm](https://github.com/user-attachments/assets/ea9f9438-34bf-4771-bbc8-335e9ea59dd7)

- [x] Tests or screenshots needed?
- [x] Code Reviewed
- [x] Manual QA

Release Notes:

- Fixed documentation tooltip reappearing after editor regains focus
AmaanBilwar pushed a commit to AmaanBilwar/zed that referenced this pull request Mar 23, 2026
…cus (zed-industries#48924)

Closes zed-industries#48922

When the editor regains focus, it internally triggers the mouse_moved
logic again. This causes the hover documentation to be shown even if it
was previously dismissed due to user editing.

This change skips mouse_moved handling when the cursor is hidden,
preventing unintended tooltip popups.


[录屏 2026-02-11
19-04-14.webm](https://github.com/user-attachments/assets/ea9f9438-34bf-4771-bbc8-335e9ea59dd7)

- [x] Tests or screenshots needed?
- [x] Code Reviewed
- [x] Manual QA

Release Notes:

- Fixed documentation tooltip reappearing after editor regains focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation tooltip reappears after navigating away and back

5 participants