Skip to content

bedrock: Add placeholder tool when summarising threads with tool history#48863

Merged
benbrandt merged 1 commit intozed-industries:mainfrom
dsturnbull:bedrock-summarise-empty-tool
Feb 16, 2026
Merged

bedrock: Add placeholder tool when summarising threads with tool history#48863
benbrandt merged 1 commit intozed-industries:mainfrom
dsturnbull:bedrock-summarise-empty-tool

Conversation

@dsturnbull
Copy link
Contributor

@dsturnbull dsturnbull commented Feb 10, 2026 •
edited
Loading 

Bedrock Converse API requires toolConfig whenever messages have tool use
or result blocks. PR #33174 handled the case where tools are defined but
tool_choice is None. This change addresses another case: the tools array
is empty (e.g. thread summarisation) but messages still have tool blocks
from conversation history. A placeholder tool satisfies the requirement.

Testing:

Tested manually by:

  1. Starting a conversation with Bedrock that uses tools
  2. Triggering thread summarisation
  3. Confirming summarisation now succeeds instead of failing with an API error

Release Notes:

  • Fixed Bedrock thread summarization failing when conversation had tools

@cla-bot
Copy link

cla-bot bot commented Feb 10, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: David Turnbull.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@zed-community-bot zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Feb 10, 2026
@dsturnbull dsturnbull force-pushed the bedrock-summarise-empty-tool branch from d6d19a2 to 9cbcd35 Compare February 10, 2026 08:56
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 10, 2026
@maxdeviant maxdeviant changed the title bedrock: Add placeholder tool when summarising threads with tool history bedrock: Add placeholder tool when summarizing threads with tool history Feb 10, 2026
@dsturnbull dsturnbull changed the title bedrock: Add placeholder tool when summarizing threads with tool history bedrock: Add placeholder tool when summarising threads with tool history Feb 11, 2026
@SomeoneToIgnore SomeoneToIgnore added the area:ai Improvement related to Agent Panel, Edit Prediction, Copilot, or other AI features label Feb 12, 2026
@dsturnbull
bedrock: Add placeholder tool when summarising threads with tool history
332b925 
Bedrock Converse API requires toolConfig whenever messages have tool use
or result blocks. PR zed-industries#33174 handled the case where tools are defined but
tool_choice is None. This change addresses another case: the tools array
is empty (e.g. thread summarisation) but messages still have tool blocks
from conversation history. A placeholder tool satisfies the requirement.

Release Notes:

- Fixed Bedrock thread summarisation failing when conversation had tools
@dsturnbull dsturnbull force-pushed the bedrock-summarise-empty-tool branch from 9cbcd35 to 332b925 Compare February 16, 2026 02:22
benbrandt
benbrandt approved these changes Feb 16, 2026
View reviewed changes
Copy link
Member

@benbrandt benbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@benbrandt benbrandt enabled auto-merge (squash) February 16, 2026 14:38
@benbrandt benbrandt self-assigned this Feb 16, 2026
@benbrandt benbrandt merged commit 323b579 into zed-industries:main Feb 16, 2026
27 checks passed
rtfeldman pushed a commit that referenced this pull request Feb 17, 2026
@dsturnbull @rtfeldman
bedrock: Add placeholder tool when summarising threads with tool hist…
4a9931d 
…ory (#48863)

Bedrock Converse API requires toolConfig whenever messages have tool use
or result blocks. PR #33174 handled the case where tools are defined but
tool_choice is None. This change addresses another case: the tools array
is empty (e.g. thread summarisation) but messages still have tool blocks
from conversation history. A placeholder tool satisfies the requirement.

Testing:

Tested manually by:
1. Starting a conversation with Bedrock that uses tools
2. Triggering thread summarisation
3. Confirming summarisation now succeeds instead of failing with an API
error

Release Notes:

- Fixed Bedrock thread summarization failing when conversation had tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbrandt benbrandt benbrandt approved these changes

Assignees

@benbrandt benbrandt

Labels

area:ai Improvement related to Agent Panel, Edit Prediction, Copilot, or other AI features cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsturnbull @benbrandt @SomeoneToIgnore