Skip to content

repl: Be more resilient with message parsing#48837

Merged
maxdeviant merged 3 commits intozed-industries:mainfrom
rgbkrk:resilient-parsing
Feb 10, 2026
Merged

repl: Be more resilient with message parsing#48837
maxdeviant merged 3 commits intozed-industries:mainfrom
rgbkrk:resilient-parsing

Conversation

@rgbkrk
Copy link
Collaborator

@rgbkrk rgbkrk commented Feb 10, 2026

Closes #21529

Show a toast when a message from a Jupyter kernel doesn't parse properly.

Discovered that some kernels don't include their execution count in an ExecuteReply which is required in the jupyter protocol. Upstream I'll go make that field either be an Option or just stick #[serde(default)] on it so it's not a change in the interface.

Release Notes:

  • Show error when parsing a message from a Jupyter kernel fails

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 10, 2026
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Feb 10, 2026
@rgbkrk rgbkrk added the area:repl repl, jupyter, notebooks, etc label Feb 10, 2026
@maxdeviant maxdeviant merged commit 303c1aa into zed-industries:main Feb 10, 2026
33 checks passed
maxdeviant pushed a commit that referenced this pull request Feb 10, 2026
Bringing in the handling of the lack of execution count noticed while
testing other kernels. xref:
#48837

Release Notes:

- N/A
@rgbkrk rgbkrk deleted the resilient-parsing branch February 10, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:repl repl, jupyter, notebooks, etc cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support troubleshooting repl

3 participants