Merged
Conversation
e3c7bf5 to
6776252
Compare
…rywhere (#48813) Makes `Workspace::test_new` `pub(crate)` so it can only be called from within the workspace crate. All external test code now uses `MultiWorkspace::test_new` instead, which reflects the actual runtime reality where `MultiWorkspace` is the window root. - `Workspace::test_new` visibility changed from `pub` to `pub(crate)` - Added `MultiWorkspace::test_add_workspace` helper for tests that need additional workspaces - Migrated ~285 call sites across 33 external files to use `MultiWorkspace::test_new` - Updated helper functions that took `&WindowHandle<Workspace>` to take `&Entity<Workspace>` Release Notes: - N/A
This should fix the test CICD and get all the tests passing Co-authored-by: Eric Holk \<eric@zed.dev\> Release Notes: - N/A --------- Co-authored-by: Eric Holk <eric@zed.dev>
Release Notes: - N/A
Panic was cause by a double workspace lease because the action register was on workspace and the agent panel got the workspace id from it's weak workspace handle Co-authored-by: Eric Holk <eric@zed.dev>
Co-authored-by: Eric Holk <eric@zed.dev>
4c329e3 to
af4d23e
Compare
This is used instead of defer_in in NewTextThread action handler to avoid a double lease panic with workspace. Co-authored-by: Eric Holk <eric@zed.dev>
Co-authored-by: Richard Feldman <oss@rtfeldman.com>
Fix rounded-corner bug when workspace switcher open Release Notes: - N/A --------- Co-authored-by: Richard Feldman <oss@rtfeldman.com>
b7f61f1 to
d1cfad2
Compare
Veykril
added a commit
that referenced
this pull request
Feb 12, 2026
KyleBarton
pushed a commit
that referenced
this pull request
Feb 13, 2026
…ce entity lease (#49058) Closes #49055 **Heads up**: This might be a naïve solution. I ran into the issue after merging latest main into #48896, and confirming that it was unrelated to that PR and incoming from upstream. Agent one-shot the fix, it works and tests pass. But I'm still wrapping my head around the changes that led to the bug. I figured the breakage is bad enough (I couldn't open devcontainers at all) to submit a possibly naïve fix. ## Fix Hoists the `find_devcontainer_configs` call out of `new_dev_container` and into the call site, where we already have a direct `&mut Workspace` reference that doesn't go through the entity map. The computed configs are passed into `new_dev_container` as an argument. ## What was happening After #48800 ("Re-add MultiWorkspace"), `with_active_or_new_workspace` nests a `Workspace` entity lease inside a `MultiWorkspace` entity lease. The `OpenDevContainer` handler was also changed from async to sync in the same PR, so `RemoteServerProjects::new_dev_container` now runs while `Workspace` is leased. Inside `new_dev_container`, a `WeakEntity<Workspace>::read_with` call tries to read `Workspace` through the entity map, finds it already leased, and panics. Release Notes: - Fixed a panic when opening the dev container modal via the `OpenDevContainer` action.
morgankrey
pushed a commit
that referenced
this pull request
Feb 19, 2026
Added 20 new actionable suggestions from merged PRs. Processed ~60 PRs in this run: - 20 actionable → queued - ~39 unactionable (no docs needed) - 1 failed (PR #48800: diff too large)
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes: