Skip to content

repl: Pluck project off of editor directly#48762

Merged
MrSubidubi merged 1 commit intozed-industries:mainfrom
rgbkrk:rgbkrk/investigate-repl-run
Feb 9, 2026
Merged

repl: Pluck project off of editor directly#48762
MrSubidubi merged 1 commit intozed-industries:mainfrom
rgbkrk:rgbkrk/investigate-repl-run

Conversation

@rgbkrk
Copy link
Collaborator

@rgbkrk rgbkrk commented Feb 9, 2026

The new multi workspace introduced in #47795 changed the window root from Workspace to MultiWorkspace, which broke Workspace::for_window() (assuming that was meant to). That returns None now. The REPL action registration in repl_sessions_ui.rs used this to check if the project was local, so when it got None, it silently skipped registering repl::Run and repl::RunInPlace on every editor.

Luckily we can just get the project directly from the editor in order to register actions.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 9, 2026
@rgbkrk rgbkrk added the area:repl repl, jupyter, notebooks, etc label Feb 9, 2026
MrSubidubi
MrSubidubi approved these changes Feb 9, 2026
View reviewed changes
Copy link
Member

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@MrSubidubi MrSubidubi self-assigned this Feb 9, 2026
@MrSubidubi MrSubidubi merged commit db6c006 into zed-industries:main Feb 9, 2026
33 checks passed
@rgbkrk
Copy link
Collaborator Author

rgbkrk commented Feb 9, 2026

Thanks for the quick fix!

It was driving me crazy while I was working on other PRs! Thank you for the quick merge.

@rgbkrk rgbkrk deleted the rgbkrk/investigate-repl-run branch February 9, 2026 09:12
MrSubidubi added a commit that referenced this pull request Feb 9, 2026
@MrSubidubi
Revert "repl: Pluck project off of editor directly (#48762)"
0c043cd 
This reverts commit db6c006.
MrSubidubi added a commit that referenced this pull request Feb 9, 2026
@MrSubidubi
Revert "repl: Pluck project off of editor directly (#48762)"
80c1726 
This reverts commit db6c006.
This was referenced Feb 9, 2026
Closed
Merged
MrSubidubi pushed a commit that referenced this pull request Feb 9, 2026
@rgbkrk
repl: Pluck project off editor directly (#48808)
196504f 
Clean up code by pulling the project off the editor directly.

Repeat of #48762 since
reversion happened in #48776.

Release Notes:

- N/A
Serophots pushed a commit to Serophots/zed that referenced this pull request Feb 9, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
495d966 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 10, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
0b0f42a 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 10, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
01b894d 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 10, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
608b664 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 10, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
d563049 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
bf109df 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
5ad267b 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
0be729f 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
50bffe2 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
87fc9a1 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
d492f87 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
1535ee4 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
20a7621 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
764d529 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
6e42413 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
4eedcc1 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk @oscarvarto
repl: Pluck project off editor directly (zed-industries#48808)
844a390 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
83a29f9 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
9494c12 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
03990a4 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
80008c2 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
e33099b 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
924e66f 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
ca6c4f2 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
6866956 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
1824510 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
28d91d3 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
1daeeab 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
f6802da 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
6e5ecb8 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
9570b83 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
1738a44 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
e0fa7eb 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
4fa99d4 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
63e7c41 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
cd538ea 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
e5a2077 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
27ec0f9 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
5c7325e 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
46cc7d9 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
6f2cfc6 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
3680d75 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
47bc6cf 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
ada3c40 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
9bf7a15 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
3c40d76 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
oscarvarto pushed a commit to oscarvarto/zed that referenced this pull request Feb 12, 2026
@rgbkrk
repl: Pluck project off editor directly (zed-industries#48808)
47522dc 
Clean up code by pulling the project off the editor directly.

Repeat of zed-industries#48762 since
reversion happened in zed-industries#48776.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrSubidubi MrSubidubi MrSubidubi approved these changes

Assignees

@MrSubidubi MrSubidubi

Labels

area:repl repl, jupyter, notebooks, etc cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rgbkrk @MrSubidubi