Skip to content

git: Follow-up fixes for custom blocks in the side-by-side diff#48747

Merged
cole-miller merged 7 commits intomainfrom
conflict-sync
Feb 9, 2026
Merged

git: Follow-up fixes for custom blocks in the side-by-side diff#48747
cole-miller merged 7 commits intomainfrom
conflict-sync

Conversation

@cole-miller
Copy link
Member

@cole-miller cole-miller commented Feb 8, 2026

  • Ensure that both sides are passed the appropriate companion data to preserve spacers when syncing
  • Remove companion handling in codepaths related to range folding, since this isn't supported in the side-by-side diff
  • Move handling of buffer folding into the block map
  • Rework set_companion to handle both DisplayMaps at once
  • DRY some code around block map syncing in the DisplayMap

TODO:

  • diagnose and fix issue that causes balancing blocks not to render properly when they are adjacent to spacers (e.g. merge conflict buttons)
  • clear balancing blocks when clearing companion
  • additional tests: interaction between spacers and balancing blocks, resizing

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 8, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Feb 8, 2026
@cole-miller cole-miller marked this pull request as ready for review February 9, 2026 01:00
@cole-miller cole-miller enabled auto-merge (squash) February 9, 2026 01:00
@cole-miller cole-miller disabled auto-merge February 9, 2026 01:06
@cole-miller cole-miller merged commit 930f484 into main Feb 9, 2026
28 checks passed
@cole-miller cole-miller deleted the conflict-sync branch February 9, 2026 01:10
cole-miller added a commit that referenced this pull request Feb 9, 2026
Restore a call to `BlockMap::read` that went missing in #48747 

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant