auto_update: Strip pre-release and build metadata from release notes URL#48570
Merged
osiewicz merged 2 commits intozed-industries:mainfrom Mar 18, 2026
Merged
Conversation
Contributor
Author
|
Friendly bump! This PR has been open for a few weeks now, just checking if there's anything I should change or if someone could take a look when they get a chance. Happy to adjust the approach if the team has a preference (see open question in the description). Thanks :) |
The release notes URL was constructed with the full semver version including build metadata (e.g. 0.218.0+preview.131.68e98a53), causing zed.dev to not find the release and redirect to /releases (Stable).
The test caused scheduler cross-talk with test_auto_update_downloads when running in parallel on CI.
f7ac1d1 to
28ca974
Compare
osiewicz
approved these changes
Mar 18, 2026
AmaanBilwar
pushed a commit
to AmaanBilwar/zed
that referenced
this pull request
Mar 18, 2026
…URL (zed-industries#48570) Without this fix, the zed.dev server doesn't recognize the version with metadata and redirects to /releases, which defaults to the Stable channel, so Preview users end up seeing Stable release notes. Closes zed-industries#47539 Changes: - Strip pre and build metadata from the semver version in release_notes_url before constructing the path, so the URL becomes /releases/preview/0.218.0 instead of /releases/preview/0.218.0-beta.1+preview.131.68e98a53. - Standardized the ordering of pre/build clearing to pre-first across all 4 call sites (2 were build-first). Open question: With this fix, the URL now points to the specific version you're running (e.g. /releases/preview/0.218.0). An alternative would be to link to /releases/preview (no version) so users can see all Preview releases, including ones newer than what they have installed. I went with per-version linking since it matches the existing intent of the code, but happy to change it if the team prefers the other approach. Release Notes: - Fixed "View Release Notes" in Preview/Stable opening the wrong release channel page due to build metadata in the URL.
AmaanBilwar
pushed a commit
to AmaanBilwar/zed
that referenced
this pull request
Mar 20, 2026
…URL (zed-industries#48570) Without this fix, the zed.dev server doesn't recognize the version with metadata and redirects to /releases, which defaults to the Stable channel, so Preview users end up seeing Stable release notes. Closes zed-industries#47539 Changes: - Strip pre and build metadata from the semver version in release_notes_url before constructing the path, so the URL becomes /releases/preview/0.218.0 instead of /releases/preview/0.218.0-beta.1+preview.131.68e98a53. - Standardized the ordering of pre/build clearing to pre-first across all 4 call sites (2 were build-first). Open question: With this fix, the URL now points to the specific version you're running (e.g. /releases/preview/0.218.0). An alternative would be to link to /releases/preview (no version) so users can see all Preview releases, including ones newer than what they have installed. I went with per-version linking since it matches the existing intent of the code, but happy to change it if the team prefers the other approach. Release Notes: - Fixed "View Release Notes" in Preview/Stable opening the wrong release channel page due to build metadata in the URL.
AmaanBilwar
pushed a commit
to AmaanBilwar/zed
that referenced
this pull request
Mar 23, 2026
…URL (zed-industries#48570) Without this fix, the zed.dev server doesn't recognize the version with metadata and redirects to /releases, which defaults to the Stable channel, so Preview users end up seeing Stable release notes. Closes zed-industries#47539 Changes: - Strip pre and build metadata from the semver version in release_notes_url before constructing the path, so the URL becomes /releases/preview/0.218.0 instead of /releases/preview/0.218.0-beta.1+preview.131.68e98a53. - Standardized the ordering of pre/build clearing to pre-first across all 4 call sites (2 were build-first). Open question: With this fix, the URL now points to the specific version you're running (e.g. /releases/preview/0.218.0). An alternative would be to link to /releases/preview (no version) so users can see all Preview releases, including ones newer than what they have installed. I went with per-version linking since it matches the existing intent of the code, but happy to change it if the team prefers the other approach. Release Notes: - Fixed "View Release Notes" in Preview/Stable opening the wrong release channel page due to build metadata in the URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, the zed.dev server doesn't recognize the version with metadata and redirects to /releases, which
defaults to the Stable channel, so Preview users end up seeing Stable release notes.
Closes #47539
Changes:
becomes /releases/preview/0.218.0 instead of /releases/preview/0.218.0-beta.1+preview.131.68e98a53.
Open question: With this fix, the URL now points to the specific version you're running (e.g.
/releases/preview/0.218.0). An alternative would be to link to /releases/preview (no version) so users can see all
Preview releases, including ones newer than what they have installed. I went with per-version linking since it matches
the existing intent of the code, but happy to change it if the team prefers the other approach.
Release Notes: