Skip to content

language_selector: Auto-select current language when opening#48475

Merged
SomeoneToIgnore merged 4 commits intozed-industries:mainfrom
cppcoffee:language_selector_index
Feb 26, 2026
Merged

language_selector: Auto-select current language when opening#48475
SomeoneToIgnore merged 4 commits intozed-industries:mainfrom
cppcoffee:language_selector_index

Conversation

@cppcoffee
Copy link
Copy Markdown
Contributor

@cppcoffee cppcoffee commented Feb 5, 2026

Release Notes:

  • Added Auto-select current language when opening language selector

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 5, 2026
@cppcoffee
Copy link
Copy Markdown
Contributor Author

cppcoffee commented Feb 5, 2026 •
edited
Loading

Before:

2026-02-05.21.02.07.mov

After:

2026-02-05.20.59.11.mov

When opening the language selector with an empty query, automatically
select and scroll to the buffer's current language instead of defaulting
to the first item in the list.

SomeoneToIgnore
SomeoneToIgnore reviewed Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement, thank you.

Can we have a test for this one to ensure this does not break in the future?
I think we could create a FakeFS project with 2 files of a different language + an empty buffer (so, 3 different files in general), and we can open the language modal on each such file to assert what's selected.

@SomeoneToIgnore SomeoneToIgnore self-assigned this Feb 24, 2026
@cppcoffee
Copy link
Copy Markdown
Contributor Author

cppcoffee commented Feb 26, 2026

Hi @SomeoneToIgnore , The test unit has been added. Please review it.

SomeoneToIgnore
SomeoneToIgnore approved these changes Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot!

@SomeoneToIgnore
Copy link
Copy Markdown
Contributor

SomeoneToIgnore commented Feb 26, 2026

Hm, I think the new right way to do things is via MultiWorkspace::test_new and that what should be used in the new test?

Otherwise, as soon as the tests start to pass, happy to merge this.

@cppcoffee cppcoffee force-pushed the language_selector_index branch from e45c041 to 98c8382 Compare February 26, 2026 13:20
@cppcoffee cppcoffee force-pushed the language_selector_index branch from 788f575 to 28b882b Compare February 26, 2026 13:28
@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) February 26, 2026 13:43
@cppcoffee
add path!
8801891 
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
auto-merge was automatically disabled February 26, 2026 14:03

Head branch was pushed to by a user without write access

@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) February 26, 2026 15:09
@SomeoneToIgnore SomeoneToIgnore merged commit 8b2829e into zed-industries:main Feb 26, 2026
27 checks passed
@cppcoffee cppcoffee deleted the language_selector_index branch February 27, 2026 01:49
rtfeldman pushed a commit that referenced this pull request Feb 27, 2026
@cppcoffee
language_selector: Auto-select current language when opening (#48475)
62e8cc8
tahayvr pushed a commit to tahayvr/zed that referenced this pull request Mar 4, 2026
@cppcoffee @tahayvr
language_selector: Auto-select current language when opening (zed-ind…
868d607 
…ustries#48475)
naaiyy pushed a commit to Glass-HQ/Glass that referenced this pull request Mar 6, 2026
@cppcoffee @naaiyy
language_selector: Auto-select current language when opening (zed-ind…
bfc38a8 
…ustries#48475)
@injust injust mentioned this pull request Mar 15, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SomeoneToIgnore SomeoneToIgnore SomeoneToIgnore approved these changes

Assignees

@SomeoneToIgnore SomeoneToIgnore

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cppcoffee @SomeoneToIgnore