terminal: Fix hyperlinks not being detected correctly when preceded by box-drawing chars#48447
Merged
probably-neb merged 1 commit intozed-industries:mainfrom Feb 13, 2026
Merged
Conversation
…rawing chars Signed-off-by: Charlie-XIAO <yx2436@nyu.edu>
Collaborator
|
Makes sense that these shouldn't be expected to be part of a link. Nice work! Thanks! |
Caio-Ze
pushed a commit
to Caio-Ze/postprod-ide
that referenced
this pull request
Feb 14, 2026
…y box-drawing chars (zed-industries#48447) Closes zed-industries#46795 This PR aims to correctly detect the hyperlinks in cases like the following, where box-drawing characters immediately precede the path (without spaces in between). ``` ╭─[Cargo.toml:55:1] ... ╰──── ``` The only false negative with the fix in this PR would be that a file path really contains leading box drawing characters which I think is very unlikely. --- Release Notes: - Fixed an issue where the hyperlinks would not be properly detected in the terminal if they were preceded by box-drawing characters (like ─, │, ┌, ┐) Signed-off-by: Charlie-XIAO <yx2436@nyu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46795
This PR aims to correctly detect the hyperlinks in cases like the following, where box-drawing characters immediately precede the path (without spaces in between).
The only false negative with the fix in this PR would be that a file path really contains leading box drawing characters which I think is very unlikely.
Release Notes: