Skip to content

Refer to devcontainer.js rather than devcontainer.cmd.js#48387

Merged
KyleBarton merged 1 commit intomainfrom
fix_windows_node_command_for_devcontainer_cli
Feb 4, 2026
Merged

Refer to devcontainer.js rather than devcontainer.cmd.js#48387
KyleBarton merged 1 commit intomainfrom
fix_windows_node_command_for_devcontainer_cli

Conversation

@KyleBarton
Copy link
Collaborator

Closes #46947

When installed with npm install -g, devcontainer gets created as devcontainer.cmd. However, when invoked as a script from node, it's still devcontainer.js. This addresses that difference so that we don't accidentally invoke devcontainer.cmd.js.

Release Notes:

  • Fixed devcontainer operation on Windows for when the devcontainer cli is not installed globally

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 4, 2026
@KyleBarton KyleBarton merged commit 13fbbae into main Feb 4, 2026
29 checks passed
@KyleBarton KyleBarton deleted the fix_windows_node_command_for_devcontainer_cli branch February 4, 2026 18:48
adb-sh pushed a commit to adb-sh/zed that referenced this pull request Feb 5, 2026
…ies#48387)

Closes zed-industries#46947

When installed with `npm install -g`, devcontainer gets created as
`devcontainer.cmd`. However, when invoked as a script from node, it's
still `devcontainer.js`. This addresses that difference so that we don't
accidentally invoke `devcontainer.cmd.js`.

Release Notes:

- Fixed devcontainer operation on Windows for when the devcontainer cli
is not installed globally
rtfeldman pushed a commit that referenced this pull request Feb 5, 2026
Closes #46947

When installed with `npm install -g`, devcontainer gets created as
`devcontainer.cmd`. However, when invoked as a script from node, it's
still `devcontainer.js`. This addresses that difference so that we don't
accidentally invoke `devcontainer.cmd.js`.

Release Notes:

- Fixed devcontainer operation on Windows for when the devcontainer cli
is not installed globally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

devcontainers does not work on Windows due to incorrect file name

1 participant