lsp: Add schema support for LSP settings field#48332
Merged
MrSubidubi merged 1 commit intozed-industries:mainfrom Feb 4, 2026
Merged
lsp: Add schema support for LSP settings field#48332MrSubidubi merged 1 commit intozed-industries:mainfrom
MrSubidubi merged 1 commit intozed-industries:mainfrom
Conversation
This extends the LSP settings schema system to also provide autocomplete
for the `settings` field (used for `workspace/configuration` responses),
in addition to the existing `initialization_options` support.
Changes:
- Add `settings_schema` method to `LspAdapter` trait and `CachedLspAdapter`
- Update schema URL paths to be more explicit:
- `lsp/{adapter}/initialization_options` for init options schema
- `lsp/{adapter}/settings` for settings schema
- Add schema resolution logic for the new settings path
- Update tests to verify both schema references
Release Notes:
- Added autocomplete support for the `settings` field in LSP configuration, complementing the existing `initialization_options` autocomplete
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MrSubidubi
approved these changes
Feb 4, 2026
rtfeldman
pushed a commit
that referenced
this pull request
Feb 5, 2026
This extends the LSP settings schema system to also provide autocomplete
for the `settings` field (used for `workspace/configuration` responses),
in addition to the existing `initialization_options` support (#).
Changes:
- Add `settings_schema` method to `LspAdapter` trait and
`CachedLspAdapter`
- Update schema URL paths to be more explicit:
- `lsp/{adapter}/initialization_options` for init options schema
- `lsp/{adapter}/settings` for settings schema
- Add schema resolution logic for the new settings path
- Update tests to verify both schema references
Release Notes:
- Added autocomplete support for the `settings` field in LSP
configuration, complementing the existing `initialization_options`
autocomplete.
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
MrSubidubi
added a commit
that referenced
this pull request
Mar 7, 2026
(This should be merged after #48332) This PR exposes the LSP settings schema functionality to extensions, allowing them to provide JSON schema for `initialization_options` and `settings` fields to enable autocomplete in settings files. New extension API methods (v0.8.0+): - `language_server_initialization_options_schema` - `language_server_settings_schema` Both methods return an optional JSON string conforming to JSON schema. Older extension versions gracefully return `None`. Release Notes: - Added support for settings schemas for the next version of the extension API so that settings autocompletion can be provided for language server settings. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: MrSubidubi <finn@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the LSP settings schema system to also provide autocomplete for the
settingsfield (used forworkspace/configurationresponses), in addition to the existinginitialization_optionssupport (#).Changes:
settings_schemamethod toLspAdaptertrait andCachedLspAdapterlsp/{adapter}/initialization_optionsfor init options schemalsp/{adapter}/settingsfor settings schemaRelease Notes:
settingsfield in LSP configuration, complementing the existinginitialization_optionsautocomplete.