project_panel: Fix test-support feature mismatch#48280
Merged
smitbarmase merged 1 commit intomainfrom Feb 3, 2026
Merged
Conversation
13 tasks
adb-sh
pushed a commit
to adb-sh/zed
that referenced
this pull request
Feb 5, 2026
Follow-up to zed-industries#46337 `project_panel` tests enable `remote/test-support` (via `workspace`/`project`), which adds `RemoteConnectionOptions::Mock`. But without `remote_connection/test-support`, the match arm for that variant isn't compiled, causing a non-exhaustive match error when testing the crate in isolation. CI doesn't catch this because `git_ui` happens to enable `remote_connection/test-support` during workspace-wide tests. Release Notes: - N/A
rtfeldman
pushed a commit
that referenced
this pull request
Feb 5, 2026
Follow-up to #46337 `project_panel` tests enable `remote/test-support` (via `workspace`/`project`), which adds `RemoteConnectionOptions::Mock`. But without `remote_connection/test-support`, the match arm for that variant isn't compiled, causing a non-exhaustive match error when testing the crate in isolation. CI doesn't catch this because `git_ui` happens to enable `remote_connection/test-support` during workspace-wide tests. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #46337
project_paneltests enableremote/test-support(viaworkspace/project), which addsRemoteConnectionOptions::Mock. But withoutremote_connection/test-support, the match arm for that variant isn't compiled, causing a non-exhaustive match error when testing the crate in isolation.CI doesn't catch this because
git_uihappens to enableremote_connection/test-supportduring workspace-wide tests.Release Notes: