Add detection of devcontainers in subfolders#47411
Add detection of devcontainers in subfolders#47411KyleBarton merged 6 commits intozed-industries:mainfrom
Conversation
9eb74bf to
429972d
Compare
|
@caiopiccirillo thanks for this! I like how you've extended the UI here, but I think it needs one slight change: There is no way to go "edit" the json before invoking it - this is behavior that's been lost from what's currently in place today. E.g. Today (with devcontainer json in only one location): Your change:
Selecting one of these configurations immediately starts a launch, without giving the user an opportunity to edit the file first. Do you think that can be addressed? |
429972d to
41d3bdb
Compare
|
Hi @KyleBarton! I have fixed the behavior of the UI. You'll see the multiple devcontainers and after choosing one of them, you'll have the old UI to edit the file or to go back. |
|
@caiopiccirillo thanks! I actually think there's a bit more to figure out here - whereas Would you have time to pair with me on this on Monday? https://calendar.app.google/aDZav1C12cGQXasB7 |
|
@caiopiccirillo FYI for tomorrow, I'll plan on hanging out in https://zed.dev/channel/dev-containers-11473-28067 - see you there. |
|
@KyleBarton Thanks, see you there! |
Co-authored-by: Caio Piccirillo <caiopiccirillo@gmail.com>
|
Things still to do:
|
- Picker search fixed - Show both devcontainer name and path (in a muted color) - Picker with font size from parent modal - Cleanup of old code
|
@KyleBarton Thanks again for your time today! I have done the changes we've discussed, if there's anything to improve, please let me know 😄 |
|
@caiopiccirillo looks great, thanks again for taking this on! |
Small fix for a bug introduced in #47411 In-progress dev container creation didn't show up in modal because of a duplicated code path. This unifies the logic and ensures that "creating dev container" shows up while creation in progress. Release Notes: - Fixed modal for creating dev container
Release Notes: - Add detection of devcontainers in subfolders --------- Co-authored-by: KyleBarton <kjb@initialcapacity.io>
Small fix for a bug introduced in zed-industries#47411 In-progress dev container creation didn't show up in modal because of a duplicated code path. This unifies the logic and ensures that "creating dev container" shows up while creation in progress. Release Notes: - Fixed modal for creating dev container
Release Notes: - Add detection of devcontainers in subfolders --------- Co-authored-by: KyleBarton <kjb@initialcapacity.io>
Small fix for a bug introduced in #47411 In-progress dev container creation didn't show up in modal because of a duplicated code path. This unifies the logic and ensures that "creating dev container" shows up while creation in progress. Release Notes: - Fixed modal for creating dev container


Release Notes: