Parse output from older version of the devcontainer CLI by looking for a JSON object in plaintext#47403
Merged
KyleBarton merged 1 commit intomainfrom Jan 22, 2026
Merged
Conversation
zcg
pushed a commit
to zcg/zedpro
that referenced
this pull request
Jan 29, 2026
…r a JSON object in plaintext (zed-industries#47403) Closes zed-industries#46852 The devcontainer CLI which ships with VS Code can be added to the user's `PATH` with the VS Code command `Dev Containers: Install devcontainer CLI`. This version of the CLI is older than what Zed was developed with, and as a result, it doesn't separate its json-formatted output and its plaintext metadata into distinct output streams. This broke parsing in the CLI adapter in Zed. This fix accounts for that, and if parsing fails, attempts to find a relevant JSON object in plaintext and tries to parse that. Tested with VSCode's version of the devcontainer CLI (`0.80.1`) as well as the up-to-date version (`0.81.1`) Release Notes: - Improved parsing of devcontainer CLI output when using earlier versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46852
The devcontainer CLI which ships with VS Code can be added to the user's
PATHwith the VS Code commandDev Containers: Install devcontainer CLI. This version of the CLI is older than what Zed was developed with, and as a result, it doesn't separate its json-formatted output and its plaintext metadata into distinct output streams. This broke parsing in the CLI adapter in Zed. This fix accounts for that, and if parsing fails, attempts to find a relevant JSON object in plaintext and tries to parse that.Tested with VSCode's version of the devcontainer CLI (
0.80.1) as well as the up-to-date version (0.81.1)Release Notes: