Skip to content

Pop end row if the end is equal to the starting sticky row#47314

Merged
KyleBarton merged 1 commit intomainfrom
fix_sticky_headers_with_no_ending_symbol
Jan 21, 2026
Merged

Pop end row if the end is equal to the starting sticky row#47314
KyleBarton merged 1 commit intomainfrom
fix_sticky_headers_with_no_ending_symbol

Conversation

@KyleBarton
Copy link
Collaborator

Closes #47307

In markdown, the outline item for a heading actually ends on the same row as the next outline item (see #47307 for the visual glitch). This change makes it so that the end row calculation accounts for that, and you don't have two different display points where content is potentially scrolling out of view. Fixed visually:

Screen.Recording.2026-01-21.at.10.23.23.AM.mov

Release Notes:

  • Fixed a visual glitch with sticky scroll headers in markdown

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 21, 2026
@KyleBarton KyleBarton enabled auto-merge (squash) January 21, 2026 18:24
@KyleBarton KyleBarton merged commit 901fe23 into main Jan 21, 2026
45 of 47 checks passed
@KyleBarton KyleBarton deleted the fix_sticky_headers_with_no_ending_symbol branch January 21, 2026 18:47
zcg pushed a commit to zcg/zedpro that referenced this pull request Jan 29, 2026
…tries#47314)

Closes zed-industries#47307

In markdown, the outline item for a heading actually ends on the same
row as the next outline item (see zed-industries#47307 for the visual glitch). This
change makes it so that the end row calculation accounts for that, and
you don't have two different display points where content is potentially
scrolling out of view. Fixed visually:



https://github.com/user-attachments/assets/e0a7e57a-fd41-4484-87e9-ac3e51d0b927


Release Notes:

- Fixed a visual glitch with sticky scroll headers in markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sticky headers visually glitches when scrolling past peer headers

1 participant