Skip to content

remote: Fix when .ssh config is missing#47310

Merged
Veykril merged 2 commits intozed-industries:mainfrom
Gaff:Gaff-fix-no-global-ssh-config
Jan 23, 2026
Merged

remote: Fix when .ssh config is missing#47310
Veykril merged 2 commits intozed-industries:mainfrom
Gaff:Gaff-fix-no-global-ssh-config

Conversation

@Gaff
Copy link
Contributor

@Gaff Gaff commented Jan 21, 2026

Closes #47309

Rewroked the file parsing loop so that if one file is missing it doesn't cause the loop to exit prematurely.

Release Notes:

  • Fixed issue where user .ssh/config file would not parse if global ssh config file was not present.

@cla-bot
Copy link

cla-bot bot commented Jan 21, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @Mike737377 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Jan 21, 2026
@maxdeviant maxdeviant changed the title Fix when .ssh config is missing. Fix when .ssh config is missing Jan 21, 2026
@zed-industries-bot
Copy link
Contributor

zed-industries-bot commented Jan 21, 2026

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against 2b10202

@Gaff Gaff force-pushed the Gaff-fix-no-global-ssh-config branch from cc8913d to 110f921 Compare January 21, 2026 17:06
@cla-bot
Copy link

cla-bot bot commented Jan 21, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @mugu on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@Gaff
Copy link
Contributor Author

Gaff commented Jan 21, 2026

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 21, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @mugu on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot
Copy link

cla-bot bot commented Jan 21, 2026

The cla-bot has been summoned, and re-checked this pull request!

@Gaff Gaff force-pushed the Gaff-fix-no-global-ssh-config branch from 110f921 to 861cfca Compare January 21, 2026 17:32
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 21, 2026
@Gaff Gaff changed the title Fix when .ssh config is missing remote: Fix when .ssh config is missing Jan 21, 2026
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril enabled auto-merge (squash) January 23, 2026 10:29
auto-merge was automatically disabled January 23, 2026 10:56

Head branch was pushed to by a user without write access

@Gaff
Copy link
Contributor Author

Gaff commented Jan 23, 2026

@Veykril fixed the formatting now I think - sorry, I'm new to rust so bear-with; thanks for approving.

@Veykril
Copy link
Member

Veykril commented Jan 23, 2026

No worries, thanks!

@Veykril Veykril enabled auto-merge (squash) January 23, 2026 11:22
@Veykril Veykril merged commit d4f2056 into zed-industries:main Jan 23, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zed does not parse .ssh/config files if the global file is missing.

3 participants