Skip to content

file_finder: Fix "Reveal in File Manager" for WSL remote connections on Windows#46856

Closed
maxmalkin wants to merge 16 commits intozed-industries:mainfrom
maxmalkin:fix/file-manager-wsl
Closed

file_finder: Fix "Reveal in File Manager" for WSL remote connections on Windows#46856
maxmalkin wants to merge 16 commits intozed-industries:mainfrom
maxmalkin:fix/file-manager-wsl

Conversation

@maxmalkin
Copy link
Contributor

Closes #46767

Release Notes:

  • Fixed "Reveal in File Manager" not working for WSL remote connections on Windows.

When using WSL remote connections on Windows, the "Reveal in File Manager" command fail without panicking.This happened because the worktree stores POSIX paths. Adds a to_unc_path method to WslConnectionOptions that converts POSIX paths to Windows UNC format. The reveal_in_finder handlers in the project panel, editor, and outline panel now check for WSL connections on Windows and convert paths accordingly before passing them to Explorer.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 15, 2026
@maxdeviant maxdeviant changed the title area:file finder: Fix "Reveal in File Manager" for WSL remote connections on Windows file_finder: Fix "Reveal in File Manager" for WSL remote connections on Windows Jan 15, 2026
@zed-industries-bot
Copy link
Contributor

zed-industries-bot commented Jan 15, 2026

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against d071d0f

@Veykril Veykril enabled auto-merge (squash) January 16, 2026 08:18
auto-merge was automatically disabled January 16, 2026 19:56

Head branch was pushed to by a user without write access

@maxmalkin maxmalkin requested a review from Veykril January 16, 2026 19:56
@SomeoneToIgnore
Copy link
Contributor

To note, there's #47236 that seems like a good part of the same issue: project panel could use a context menu item same as other OSes have it.

Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril enabled auto-merge (squash) January 21, 2026 12:55
auto-merge was automatically disabled January 22, 2026 11:24

Pull request was closed

pull bot pushed a commit to blog2i2j/zed-industries.._..zed that referenced this pull request Jan 22, 2026
Assimilates zed-industries#46856 and adds
support for reveal file manager in the project panel on wsl. Closes
zed-industries#46856

Release Notes:

- Fixed "Reveal in File Manager" not working for WSL remote connections
on Windows.
- Show "Reveal in File Manager" in the project panel context menu on WSL

---------

Co-authored-by: Max Malkin <maxim_malkin@outlook.com>
zcg pushed a commit to zcg/zedpro that referenced this pull request Jan 29, 2026
Assimilates zed-industries#46856 and adds
support for reveal file manager in the project panel on wsl. Closes
zed-industries#46856

Release Notes:

- Fixed "Reveal in File Manager" not working for WSL remote connections
on Windows.
- Show "Reveal in File Manager" in the project panel context menu on WSL

---------

Co-authored-by: Max Malkin <maxim_malkin@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Reveal in File Manager" not working for WSL remote connections on Windows

5 participants