html: Exclude all brackets from bracket colorization#46808
Merged
MrSubidubi merged 1 commit intomainfrom Jan 14, 2026
Merged
Conversation
SomeoneToIgnore
approved these changes
Jan 14, 2026
rtfeldman
pushed a commit
that referenced
this pull request
Jan 14, 2026
Closes #45755 Rainbow brackets in HTML files do not really make sense - a tag is always enclosed in angled brackets. With our current approach, that means that we will highlight all brackets in HTML files with the same color, because well, these angled brackets do not quite behave like in other languages. Hence, let themes color this again and just exluce HTML angled brackets from rainbow bracket colorization, as it is no real rainbow bracket colorization anyway. Release Notes: - N/A
MrSubidubi
pushed a commit
that referenced
this pull request
Mar 11, 2026
…or TSX (#51311) ## Summary Angle brackets in TSX (`<`, `>`, `/>`, `</`) are always paired with JSX tag syntax — they don't indicate bracket nesting depth — so rainbow colorization adds noise without useful information. This mirrors #46808, which applied the same fix to the HTML extension. ## Changes - Added `(#set! rainbow.exclude)` to all three angle bracket patterns in `crates/languages/src/tsx/brackets.scm` ## Before / After Before: angle brackets in JSX tags receive rainbow colors alongside `{}`, `()`, `[]`, making every tag visually noisy. After: only `{}`, `()`, and `[]` receive rainbow colors — angle brackets are excluded, matching the HTML extension behavior. > Screenshots: I don't have a built copy of Zed handy to attach — happy to add one if a maintainer needs it before merging. Release Notes: - Removed rainbow bracket colorization for angled brackets within TSX.
tommyming
pushed a commit
to tommyming/zed
that referenced
this pull request
Mar 13, 2026
…or TSX (zed-industries#51311) ## Summary Angle brackets in TSX (`<`, `>`, `/>`, `</`) are always paired with JSX tag syntax — they don't indicate bracket nesting depth — so rainbow colorization adds noise without useful information. This mirrors zed-industries#46808, which applied the same fix to the HTML extension. ## Changes - Added `(#set! rainbow.exclude)` to all three angle bracket patterns in `crates/languages/src/tsx/brackets.scm` ## Before / After Before: angle brackets in JSX tags receive rainbow colors alongside `{}`, `()`, `[]`, making every tag visually noisy. After: only `{}`, `()`, and `[]` receive rainbow colors — angle brackets are excluded, matching the HTML extension behavior. > Screenshots: I don't have a built copy of Zed handy to attach — happy to add one if a maintainer needs it before merging. Release Notes: - Removed rainbow bracket colorization for angled brackets within TSX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45755
Rainbow brackets in HTML files do not really make sense - a tag is always enclosed in angled brackets. With our current approach, that means that we will highlight all brackets in HTML files with the same color, because well, these angled brackets do not quite behave like in other languages.
Hence, let themes color this again and just exluce HTML angled brackets from rainbow bracket colorization, as it is no real rainbow bracket colorization anyway.
Release Notes: