Skip to content

settings_ui: Fix settings search missing results when BM25 finds partial matches#46349

Merged
smitbarmase merged 1 commit intomainfrom
fix-settings-ui-fuzzy-search
Jan 8, 2026
Merged

settings_ui: Fix settings search missing results when BM25 finds partial matches#46349
smitbarmase merged 1 commit intomainfrom
fix-settings-ui-fuzzy-search

Conversation

@smitbarmase
Copy link
Member

Closes #44038

BM25 results were fully replacing fuzzy results, which caused some items to disappear from search. For example, "Show Menus" wouldn’t show up when searching for "menu". This happened due to limitations in the Porter stemmer used by the library. Fuzzy search matched correctly, but its results were getting overwritten. We now merge both result sets instead.

Release Notes:

  • Fixed an issue where settings search missed some results, like "Show Menus" when searching for "menu".

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 8, 2026
@smitbarmase smitbarmase merged commit 5ae3cf0 into main Jan 8, 2026
24 checks passed
@smitbarmase smitbarmase deleted the fix-settings-ui-fuzzy-search branch January 8, 2026 10:43
baldwindavid added a commit to baldwindavid/zed that referenced this pull request Jan 8, 2026
* main: (349 commits)
  component_preview: Fix license symlink (zed-industries#46379)
  Do not react on already observed buffer edits' versions (zed-industries#46308)
  Fix EP CLI output flicker (zed-industries#46313)
  vim: Fix bug where repeat operator could lead to unrecoverable replaying state (zed-industries#46376)
  vim: Implement text-based matching bracket logic for Vim '%' motion to correctly find pairs within comments (zed-industries#45559)
  Improve LSP button error message (zed-industries#46377)
  agent: Make reject/accept keybindings consistent with restore/stage (zed-industries#46373)
  Enable test-support features for some dev dependencies (zed-industries#46370)
  Capture terminal output when thread is interrupted (zed-industries#46306)
  Inline assistant tools: no more feature flag (zed-industries#46107)
  Add `ep split` subcommand for dataset splitting (zed-industries#46364)
  lsp_button: Fix long LSP version label (zed-industries#46359)
  remote: Introduce a proper mock remote connection (zed-industries#46337)
  ep: Allow matching patches against files without trailing newlines (zed-industries#46357)
  docs: Update "Custom Keybindings for Extension-Based Agents section" to include a troubleshooting note for defining an agent name (zed-industries#46144)
  Fail early if clangd is downloaded on aarch Linux (zed-industries#46346)
  ep: Handle errored requests in Anthropic batches (zed-industries#46351)
  settings_ui: Fix settings search missing results when BM25 finds partial matches (zed-industries#46349)
  workspace: Unpreview active tab when closing other tabs (zed-industries#46294)
  terminal: Skip SHLVL when loading login shell environment (zed-industries#46273)
  ...
rtfeldman pushed a commit that referenced this pull request Jan 9, 2026
…ial matches (#46349)

Closes #44038

BM25 results were fully replacing fuzzy results, which caused some items
to disappear from search. For example, "Show Menus" wouldn’t show up
when searching for "menu". This happened due to limitations in the
Porter stemmer used by the library. Fuzzy search matched correctly, but
its results were getting overwritten. We now merge both result sets
instead.

Release Notes:

- Fixed an issue where settings search missed some results, like "Show
Menus" when searching for "menu".
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
…ial matches (zed-industries#46349)

Closes zed-industries#44038

BM25 results were fully replacing fuzzy results, which caused some items
to disappear from search. For example, "Show Menus" wouldn’t show up
when searching for "menu". This happened due to limitations in the
Porter stemmer used by the library. Fuzzy search matched correctly, but
its results were getting overwritten. We now merge both result sets
instead.

Release Notes:

- Fixed an issue where settings search missed some results, like "Show
Menus" when searching for "menu".
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
…ial matches (zed-industries#46349)

Closes zed-industries#44038

BM25 results were fully replacing fuzzy results, which caused some items
to disappear from search. For example, "Show Menus" wouldn’t show up
when searching for "menu". This happened due to limitations in the
Porter stemmer used by the library. Fuzzy search matched correctly, but
its results were getting overwritten. We now merge both result sets
instead.

Release Notes:

- Fixed an issue where settings search missed some results, like "Show
Menus" when searching for "menu".
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Feb 15, 2026
…ial matches (zed-industries#46349)

Closes zed-industries#44038

BM25 results were fully replacing fuzzy results, which caused some items
to disappear from search. For example, "Show Menus" wouldn’t show up
when searching for "menu". This happened due to limitations in the
Porter stemmer used by the library. Fuzzy search matched correctly, but
its results were getting overwritten. We now merge both result sets
instead.

Release Notes:

- Fixed an issue where settings search missed some results, like "Show
Menus" when searching for "menu".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Searching for "menu" in settings does not show "Window & Layout -> Show Menus"

1 participant