git: Don't show binary files in past commit view#46312
Merged
cole-miller merged 2 commits intomainfrom Jan 8, 2026
Merged
Conversation
|
|
||
| /// Detects if content is binary by checking for NUL bytes in the first 8000 bytes. | ||
| /// This matches git's binary detection heuristic. | ||
| pub fn is_binary_content(content: &[u8]) -> bool { |
Contributor
There was a problem hiding this comment.
Wanted to mention
zed/crates/worktree/src/worktree.rs
Line 6012 in 42af91d
Would be great to unify the code if this bit gets to evolve some day.
rtfeldman
pushed a commit
that referenced
this pull request
Jan 9, 2026
Also improves the commit view to use the same status-based buffer header visual overrides as the project diff as a driveby. Fixes #45735 Release Notes: - git: Binary files are no longer shown in garbled form when viewing an old commit.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
Also improves the commit view to use the same status-based buffer header visual overrides as the project diff as a driveby. Fixes zed-industries#45735 Release Notes: - git: Binary files are no longer shown in garbled form when viewing an old commit.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
Also improves the commit view to use the same status-based buffer header visual overrides as the project diff as a driveby. Fixes zed-industries#45735 Release Notes: - git: Binary files are no longer shown in garbled form when viewing an old commit.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Feb 15, 2026
Also improves the commit view to use the same status-based buffer header visual overrides as the project diff as a driveby. Fixes zed-industries#45735 Release Notes: - git: Binary files are no longer shown in garbled form when viewing an old commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improves the commit view to use the same status-based buffer header visual overrides as the project diff as a driveby.
Fixes #45735
Release Notes: