settings_ui: Fix theme not being configurable in certain scenarios#46069
Merged
MrSubidubi merged 1 commit intomainfrom Jan 5, 2026
Merged
settings_ui: Fix theme not being configurable in certain scenarios#46069MrSubidubi merged 1 commit intomainfrom
MrSubidubi merged 1 commit intomainfrom
Conversation
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
…46069) Closes #44091 The issue here was that we were missing a proper default for `ThemeSelection`. This is a disadvantage of not having the defaults in code but actually in the `default.json`, so this here basically copies the default from the `default.json` into code for the settings UI to work properly. Release Notes: - Fixed an issue where the theme was not configurable from the settings UI if no theme was configured prior.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ed-industries#46069) Closes zed-industries#44091 The issue here was that we were missing a proper default for `ThemeSelection`. This is a disadvantage of not having the defaults in code but actually in the `default.json`, so this here basically copies the default from the `default.json` into code for the settings UI to work properly. Release Notes: - Fixed an issue where the theme was not configurable from the settings UI if no theme was configured prior.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ed-industries#46069) Closes zed-industries#44091 The issue here was that we were missing a proper default for `ThemeSelection`. This is a disadvantage of not having the defaults in code but actually in the `default.json`, so this here basically copies the default from the `default.json` into code for the settings UI to work properly. Release Notes: - Fixed an issue where the theme was not configurable from the settings UI if no theme was configured prior.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Feb 15, 2026
…ed-industries#46069) Closes zed-industries#44091 The issue here was that we were missing a proper default for `ThemeSelection`. This is a disadvantage of not having the defaults in code but actually in the `default.json`, so this here basically copies the default from the `default.json` into code for the settings UI to work properly. Release Notes: - Fixed an issue where the theme was not configurable from the settings UI if no theme was configured prior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44091
The issue here was that we were missing a proper default for
ThemeSelection. This is a disadvantage of not having the defaults in code but actually in thedefault.json, so this here basically copies the default from thedefault.jsoninto code for the settings UI to work properly.Release Notes: