typescript: Use @type instead of @type.builtin in highlights#46068
Merged
typescript: Use @type instead of @type.builtin in highlights#46068
Conversation
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
Closes #45251 In #44532 the syntax highlighting of JS/TS was improved, but we only used `type.builtin` for a specific case. This resulted in less consistent syntax highlighting. Not all themes have this specific token and we don't use `type.builtin` in other places either, so while this is a little less specific it is more consistent. Release Notes: - Improved syntax highlighting consistency for builtins in JavaScript and TypeScript
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ustries#46068) Closes zed-industries#45251 In zed-industries#44532 the syntax highlighting of JS/TS was improved, but we only used `type.builtin` for a specific case. This resulted in less consistent syntax highlighting. Not all themes have this specific token and we don't use `type.builtin` in other places either, so while this is a little less specific it is more consistent. Release Notes: - Improved syntax highlighting consistency for builtins in JavaScript and TypeScript
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ustries#46068) Closes zed-industries#45251 In zed-industries#44532 the syntax highlighting of JS/TS was improved, but we only used `type.builtin` for a specific case. This resulted in less consistent syntax highlighting. Not all themes have this specific token and we don't use `type.builtin` in other places either, so while this is a little less specific it is more consistent. Release Notes: - Improved syntax highlighting consistency for builtins in JavaScript and TypeScript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45251
In #44532 the syntax highlighting of JS/TS was improved, but we only used
type.builtinfor a specific case. This resulted in less consistent syntax highlighting. Not all themes have this specific token and we don't usetype.builtinin other places either, so while this is a little less specific it is more consistent.Release Notes: