Make extension key context case-insensitive#45961
Make extension key context case-insensitive#45961MrSubidubi merged 2 commits intozed-industries:mainfrom
extension key context case-insensitive#45961Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @krisfur on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this!
Curious though, perhaps this is better solved for all languages if we just make this case-insensitive here
zed/crates/editor/src/editor.rs
Lines 2675 to 2684 in fa4eaf4
What do you think?
|
Great shout @MrSubidubi! Simple .to_lowercase() and done, worked locally for me. Pushed and ready - it replaces .into_owned() as to_lowercase() already returns a new string so no other mangling needed. |
MrSubidubi
left a comment
There was a problem hiding this comment.
Nice, thanks for the quick follow-up, looks good! Thank you and congratulations to your first contribution! 🎉
extension key context case-insensitive
Closes zed-industries#45960 Release Notes: - Made the `extension` key context case-insensitive. This e.g. enables the `markdown: Open Preview` action to also handle files where the extension is capitalised as MD (case-sensitive file system).
Closes zed-industries#45960 Release Notes: - Made the `extension` key context case-insensitive. This e.g. enables the `markdown: Open Preview` action to also handle files where the extension is capitalised as MD (case-sensitive file system).
Closes #45960
Release Notes:
extensionkey context case-insensitive. This e.g. enables themarkdown: Open Previewaction to also handle files where the extension is capitalised as MD (case-sensitive file system).