agent_servers: Fix process leaks after terminating ACP server#45902
Merged
agent_servers: Fix process leaks after terminating ACP server#45902
Conversation
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
Closes #45211 This ensures that all sub-processes that were launched by the ACP server are terminated. One scenario where this is easily reproducible: - Start a new Claude Code ACP session - Submit a prompt - While Claude-code is still responding, start a new session - The `claude-code` subprocess is leaked from the previous session (The Claude-code SDK runs the Claude-code binary in a sub process) This PR fixes this by using process groups on Unix. It does not fix the process leaks on Windows yet (will follow up with another PR) Release Notes: - Fixed an issue where subprocesses of ACP servers could be leaked after starting a new session
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…dustries#45902) Closes zed-industries#45211 This ensures that all sub-processes that were launched by the ACP server are terminated. One scenario where this is easily reproducible: - Start a new Claude Code ACP session - Submit a prompt - While Claude-code is still responding, start a new session - The `claude-code` subprocess is leaked from the previous session (The Claude-code SDK runs the Claude-code binary in a sub process) This PR fixes this by using process groups on Unix. It does not fix the process leaks on Windows yet (will follow up with another PR) Release Notes: - Fixed an issue where subprocesses of ACP servers could be leaked after starting a new session
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…dustries#45902) Closes zed-industries#45211 This ensures that all sub-processes that were launched by the ACP server are terminated. One scenario where this is easily reproducible: - Start a new Claude Code ACP session - Submit a prompt - While Claude-code is still responding, start a new session - The `claude-code` subprocess is leaked from the previous session (The Claude-code SDK runs the Claude-code binary in a sub process) This PR fixes this by using process groups on Unix. It does not fix the process leaks on Windows yet (will follow up with another PR) Release Notes: - Fixed an issue where subprocesses of ACP servers could be leaked after starting a new session
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Feb 15, 2026
…dustries#45902) Closes zed-industries#45211 This ensures that all sub-processes that were launched by the ACP server are terminated. One scenario where this is easily reproducible: - Start a new Claude Code ACP session - Submit a prompt - While Claude-code is still responding, start a new session - The `claude-code` subprocess is leaked from the previous session (The Claude-code SDK runs the Claude-code binary in a sub process) This PR fixes this by using process groups on Unix. It does not fix the process leaks on Windows yet (will follow up with another PR) Release Notes: - Fixed an issue where subprocesses of ACP servers could be leaked after starting a new session
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45211
This ensures that all sub-processes that were launched by the ACP server are terminated. One scenario where this is easily reproducible:
claude-codesubprocess is leaked from the previous session (The Claude-code SDK runs the Claude-code binary in a sub process)This PR fixes this by using process groups on Unix.
It does not fix the process leaks on Windows yet (will follow up with another PR)
Release Notes: